Issue 9311043: code review 9311043: runtime: fix crash in select

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9311043: code review 9311043: runtime: fix crash in select (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by iant

Modified:
10 years, 11 months ago

Reviewers:

CC:
golang-dev, r

Visibility:
Public.

Description

runtime: fix crash in select runtime.park() can access freed select descriptor due to a racing free in another thread. See the comment for details. Slightly modified version of dvyukov's CL 9259045. No test yet. Before this CL, the test described in issue 5422 would fail about every 40 times for me. With this CL, I ran the test 5900 times with no failures. Fixes issue 5422.

Patch Set 1 #

Patch Set 2 : diff -r 87762a7629b4 https://go.googlecode.com/hg/ #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -9 lines)			Patch
	M	src/pkg/runtime/chan.c	View		1 chunk	+20 lines, -9 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 11 months ago (2013-05-08 21:54:41 UTC) #1

iant

10 years, 11 months ago (2013-05-08 21:58:38 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=53bc96b4c0c7 ***

runtime: fix crash in select
runtime.park() can access freed select descriptor
due to a racing free in another thread.
See the comment for details.

Slightly modified version of dvyukov's CL 9259045.

No test yet.  Before this CL, the test described in issue 5422
would fail about every 40 times for me.  With this CL, I ran
the test 5900 times with no failures.

Fixes issue 5422.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/9311043

Expand All Messages | Collapse All Messages