Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(858)

Issue 9307043: Allow silent failures on some perm denied ops.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by matthew.scott
Modified:
11 years, 5 months ago
Reviewers:
bac, jeff.pihach, mp+163033
Visibility:
Public.

Description

Allow silent failures on some perm denied ops. Some operations are not allowed in read-only mode, but, per user input, permission denied errors are not necessarily helpful. This prevents the notifications from being created, but still prevents the operation, and still logs to the console. https://code.launchpad.net/~makyo/juju-gui/update-annotations-fix/+merge/163033 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Allow silent failures on some perm denied ops. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -4 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/base.js View 2 chunks +20 lines, -2 lines 0 comments Download
M test/test_env_python.js View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 4
matthew.scott
Please take a look.
11 years, 5 months ago (2013-05-08 18:41:20 UTC) #1
jeff.pihach
LGTM - Thanks for this fix! I would like to see a follow-up task to ...
11 years, 5 months ago (2013-05-08 19:17:52 UTC) #2
bac
LGTM
11 years, 5 months ago (2013-05-08 19:18:17 UTC) #3
matthew.scott
11 years, 5 months ago (2013-05-08 20:21:56 UTC) #4
*** Submitted:

Allow silent failures on some perm denied ops.

Some operations are not allowed in read-only mode, but, per user input,
permission denied errors are not necessarily helpful.  This prevents the
notifications from being created, but still prevents the operation, and still
logs to the console.

R=jeff.pihach, bac
CC=
https://codereview.appspot.com/9307043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b