Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1736)

Issue 92760044: code review 92760044: runtime: use duff zero and copy to initialize memory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by khr
Modified:
2 months ago
Reviewers:
ianbramwel573, rsc
CC:
golang-codereviews, khr1, bradfitz, josharian, dave_cheney.net, rsc
Visibility:
Public.

Description

runtime: use duff zero and copy to initialize memory benchmark old ns/op new ns/op delta BenchmarkCopyFat512 1307 329 -74.83% BenchmarkCopyFat256 666 169 -74.62% BenchmarkCopyFat1024 2617 671 -74.36% BenchmarkCopyFat128 343 89.0 -74.05% BenchmarkCopyFat64 182 48.9 -73.13% BenchmarkCopyFat32 103 28.8 -72.04% BenchmarkClearFat128 102 46.6 -54.31% BenchmarkClearFat512 344 167 -51.45% BenchmarkClearFat64 50.5 26.5 -47.52% BenchmarkClearFat256 147 87.2 -40.68% BenchmarkClearFat32 22.7 16.4 -27.75% BenchmarkClearFat1024 511 662 +29.55% Fixes issue 7624

Patch Set 1 #

Patch Set 2 : diff -r 9eacb9c0d810 https://khr%40golang.org@code.google.com/p/go/ #

Total comments: 4

Patch Set 3 : diff -r 490c2d4fda2b https://khr%40golang.org@code.google.com/p/go/ #

Total comments: 2

Patch Set 4 : diff -r d797b2316601 https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 5 : diff -r a6cb2adc55eb https://khr%40golang.org@code.google.com/p/go/ #

Patch Set 6 : diff -r a6cb2adc55eb https://khr%40golang.org@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+568 lines, -37 lines) Patch
M src/cmd/5g/cgen.c View 1 2 2 chunks +37 lines, -1 line 0 comments Download
M src/cmd/5g/ggen.c View 6 chunks +73 lines, -28 lines 0 comments Download
M src/cmd/5g/peep.c View 1 2 3 1 chunk +21 lines, -1 line 0 comments Download
M src/cmd/5g/prog.c View 1 chunk +6 lines, -0 lines 0 comments Download
M src/cmd/5g/reg.c View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/5l/5.out.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/liblink/asm5.c View 4 chunks +7 lines, -1 line 0 comments Download
M src/liblink/obj5.c View 2 chunks +4 lines, -0 lines 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 2 3 1 chunk +408 lines, -0 lines 0 comments Download
M src/pkg/runtime/memmove_test.go View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13
khr
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://khr%40golang.org@code.google.com/p/go/
10 years, 3 months ago (2014-04-25 06:08:56 UTC) #1
khr1
Dave and Russ, please take a look. I am in particular interested in whether I ...
10 years, 3 months ago (2014-04-25 06:12:16 UTC) #2
khr
On 2014/04/25 06:12:16, khr1 wrote: > Dave and Russ, please take a look. I am ...
10 years, 3 months ago (2014-04-25 06:13:36 UTC) #3
bradfitz
Fixes Issue 7624 in CL description?
10 years, 3 months ago (2014-04-25 13:26:13 UTC) #4
josharian
Thanks for showing ARM some love! A few nits below. Also, BenchmarkClearFat1024 looks anomalous. Do ...
10 years, 3 months ago (2014-04-25 16:34:55 UTC) #5
khr
On 2014/04/25 16:34:55, josharian wrote: > Thanks for showing ARM some love! A few nits ...
10 years, 3 months ago (2014-04-26 00:18:21 UTC) #6
dave_cheney.net
Some results from a pandaboard (dual Cortex-A9), I can't replicate the slowdown on ClearFat1024 benchmark ...
10 years, 3 months ago (2014-04-26 14:55:41 UTC) #7
josharian
> > Also, BenchmarkClearFat1024 looks anomalous. Do you have a sense for why it > ...
10 years, 2 months ago (2014-05-01 18:45:19 UTC) #8
rsc
LGTM I've finally worked out the numbers there and I agree with what you had. ...
10 years, 2 months ago (2014-05-06 14:08:57 UTC) #9
khr
*** Submitted as https://code.google.com/p/go/source/detail?r=e473e77e84ff *** runtime: use duff zero and copy to initialize memory benchmark ...
10 years, 2 months ago (2014-05-07 20:17:13 UTC) #10
ianbramwel573
On 2014/05/07 20:17:13, khr wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=e473e77e84ff *** > > runtime: use ...
2 months, 2 weeks ago (2024-05-06 21:18:12 UTC) #11
ianbramwel573
On 2014/05/07 20:17:13, khr wrote: > *** Submitted as https://code.google.com/p/go/source/detail?r=e473e77e84ff *** > > runtime: use ...
2 months, 2 weeks ago (2024-05-06 21:18:14 UTC) #12
ianbramwel573
2 months, 2 weeks ago (2024-05-06 21:19:48 UTC) #13
Message was sent while issue was closed.
On 2024/05/06 21:18:14, ianbramwel573 wrote:
> On 2014/05/07 20:17:13, khr wrote:
> > *** Submitted as https://code.google.com/p/go/source/detail?r=e473e77e84ff
***
> > 
> > runtime: use duff zero and copy to initialize memory
> > 
> > benchmark                 old ns/op     new ns/op     delta
> > BenchmarkCopyFat512       1307          329           -74.83%
> > BenchmarkCopyFat256       666           169           -74.62%
> > BenchmarkCopyFat1024      2617          671           -74.36%
> > BenchmarkCopyFat128       343           89.0          -74.05%
> > BenchmarkCopyFat64        182           48.9          -73.13%
> > BenchmarkCopyFat32        103           28.8          -72.04%
> > BenchmarkClearFat128      102           46.6          -54.31%
> > BenchmarkClearFat512      344           167           -51.45%
> > BenchmarkClearFat64       50.5          26.5          -47.52%
> > BenchmarkClearFat256      147           87.2          -40.68%
> > BenchmarkClearFat32       22.7          16.4          -27.75%
> > BenchmarkClearFat1024     511           662           +29.55%
> > 
> > Fixes issue 7624
> > 
> > LGTM=rsc
> > R=golang-codereviews, khr, bradfitz, josharian, dave, rsc
> > CC=golang-codereviews
> > https://codereview.appspot.com/92760044
> 
> >debugging issues
> JavaScript solve the problem.Bramwelian
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b