LGTM On Tue, May 7, 2013 at 11:24 AM, <r@golang.org> wrote: > Reviewers: golang-dev1, > ...
11 years, 10 months ago
(2013-05-07 18:33:27 UTC)
#2
LGTM
On Tue, May 7, 2013 at 11:24 AM, <r@golang.org> wrote:
> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> effective_go.html: be more accepting in the guidelines for interface
> names
> Fixes issue 5421.
>
> Please review this at
https://codereview.appspot.**com/9274043/<https://codereview.appspot.com/9274...
>
> Affected files:
> M doc/effective_go.html
>
>
> Index: doc/effective_go.html
> ==============================**==============================**=======
> --- a/doc/effective_go.html
> +++ b/doc/effective_go.html
> @@ -403,8 +403,10 @@
>
> <p>
> By convention, one-method interfaces are named by
> -the method name plus the -er suffix: <code>Reader</code>,
> -<code>Writer</code>, <code>Formatter</code> etc.
> +the method name plus an -er suffix or similar modification
> +to construct an agent noun: <code>Reader</code>,
> +<code>Writer</code>, <code>Formatter</code>,
> +<code>CloseNotifier</code> etc.
> </p>
>
> <p>
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>
*** Submitted as https://code.google.com/p/go/source/detail?r=bbe324079abe *** effective_go.html: be more accepting in the guidelines for interface names ...
11 years, 10 months ago
(2013-05-07 18:41:41 UTC)
#4
Issue 9274043: code review 9274043: effective_go.html: be more accepting in the guidelines ...
(Closed)
Created 11 years, 10 months ago by r
Modified 11 years, 10 months ago
Reviewers:
Base URL:
Comments: 0