Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(78)

Issue 92660046: Replace LoggingSuite with IsolationSuite.

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 3 months ago by frankban
Modified:
5 years, 3 months ago
Reviewers:
gz, mp+221210
Visibility:
Public.

Description

Replace LoggingSuite with IsolationSuite. The logging package no longer exist in github.com/juju/testing. https://code.launchpad.net/~frankban/golxc/fix-logging-suite/+merge/221210 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Replace LoggingSuite with IsolationSuite. #

Patch Set 3 : Replace LoggingSuite with IsolationSuite. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M golxc_test.go View 1 4 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4
frankban
Please take a look.
5 years, 3 months ago (2014-05-28 11:54:27 UTC) #1
frankban
Please take a look.
5 years, 3 months ago (2014-05-28 12:06:51 UTC) #2
gz
LGTM. At least is explict about leaking your PATH in.
5 years, 3 months ago (2014-05-28 13:22:03 UTC) #3
frankban
5 years, 3 months ago (2014-05-28 13:24:28 UTC) #4
*** Submitted:

Replace LoggingSuite with IsolationSuite.

The logging package no longer exist in github.com/juju/testing.

R=gz
CC=
https://codereview.appspot.com/92660046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b