Issue 9252043: Drag out to export

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9252043: Drag out to export

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by bcsaller

Modified:
10 years, 11 months ago

Reviewers:
mp+162691, teknico, gary.poster

Visibility:
Public.

Description

Drag out to export Dragging the environment icon in the nav to another supporting GUI app will create DnD export/import chain. DnD export is very limited now and only supports dragging from one GUI instance to another. Because of this its hidden behind a feature flag. /:flags:/dndexport/ https://code.launchpad.net/~bcsaller/juju-gui/export-ui/+merge/162691 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Drag out to export #

Patch Set 3 : Drag out to export #

Patch Set 4 : Drag out to export #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+314 lines, -34 lines)			Patch
M	.jshintignore	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	.jshintrc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	Makefile	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	[revision details]	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/app.js	View	1 2 3	4 chunks	+27 lines, -2 lines	0 comments	Download
A	app/assets/javascripts/FileSaver.js	View	1	1 chunk	+216 lines, -0 lines	0 comments	Download
M	app/index.html	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	app/modules-debug.js	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	app/views/topology/importexport.js	View	1 2 3	1 chunk	+53 lines, -28 lines	0 comments	Download
M	bin/merge-files	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gary.poster

LGTM, with protecting the drag story (which surprised me in QA, as we discussed, because ...

10 years, 11 months ago (2013-05-14 21:23:18 UTC) #3

teknico

10 years, 11 months ago (2013-05-15 10:48:41 UTC) #6

LGTM. I did not review FileSaver.js, I don't know how it's supposed to work and
the wide indentation makes it unreadable anyway.

Expand All Messages | Collapse All Messages