code review 9251043: runtime: make arm signal handler call runtime.badsignal

runtime: make arm signal handler call runtime.badsignal
In preparation for CL 9249043 (already submitted).

Fixes issue 5553.

[minux1, 2013-05-21 20:57:21]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[iant, 2013-05-21 22:21:37]

LGTM

https://codereview.appspot.com/9251043/diff/8001/src/pkg/runtime/sys_freebsd_...
File src/pkg/runtime/sys_freebsd_arm.s (right):

https://codereview.appspot.com/9251043/diff/8001/src/pkg/runtime/sys_freebsd_...
src/pkg/runtime/sys_freebsd_arm.s:162: CMP $0, m
This is the only occurrence of m in this file.  I wonder if it would be clearer
to use R9 here.  Or whether we should (in a different CL) replace R9 with m and
R10 with g where appropriate.

[capnm, 2013-05-24 12:33:25]

LGTM + fixes Issue 5553

uname -a
Linux rpi 3.6.11+ #452 PREEMPT Fri May 17 14:25:40 BST 2013 armv6l GNU/Linux

=== RUN Test5337
--- PASS: Test5337 (0.00 seconds)

On 2013/05/21 20:57:21, minux wrote:
> Hello mailto:golang-dev@googlegroups.com (cc:
mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go/

[dave_cheney.net, 2013-05-24 12:52:50]

LGTM. Please add Fixes issue 5553.

[minux1, 2013-05-27 12:47:07]

*** Submitted as https://code.google.com/p/go/source/detail?r=fae6ab78c055 ***

runtime: make arm signal handler call runtime.badsignal
In preparation for CL 9249043 (already submitted).

Fixes issue 5553.

R=golang-dev, iant, capnm9, dave
CC=golang-dev
https://codereview.appspot.com/9251043

https://codereview.appspot.com/9251043/diff/8001/src/pkg/runtime/sys_freebsd_...
File src/pkg/runtime/sys_freebsd_arm.s (right):

https://codereview.appspot.com/9251043/diff/8001/src/pkg/runtime/sys_freebsd_...
src/pkg/runtime/sys_freebsd_arm.s:162: CMP $0, m
On 2013/05/21 22:21:37, iant wrote:
> This is the only occurrence of m in this file.  I wonder if it would be
clearer
> to use R9 here.  Or whether we should (in a different CL) replace R9 with m
and
> R10 with g where appropriate.
I will send a CL to replace R9 and R10 with m and g when appropriate
(most of the uses of R9 doesn't need to be m, will use something else)