Issue 9239046: Beams: be transparent if the first stem is transparent; issue 2866

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9239046: Beams: be transparent if the first stem is transparent; issue 2866 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by Keith

Modified:
10 years, 10 months ago

Reviewers:
dak

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Beams: be transparent if the first stem is transparent; issue 2866 so that \hideNotes does not hide automatic beams that could have, but did not, start on a hidden note.

Patch Set 1 #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	ly/property-init.ly	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	scm/define-grobs.scm	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	scm/music-functions.scm	View	1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dak

https://codereview.appspot.com/9239046/diff/1/scm/music-functions.scm File scm/music-functions.scm (left): https://codereview.appspot.com/9239046/diff/1/scm/music-functions.scm#oldcode1947 scm/music-functions.scm:1947: (map (lambda (st) That's a case for for-each, not ...

10 years, 11 months ago (2013-05-15 07:45:21 UTC) #1

Keith

10 years, 11 months ago (2013-05-20 06:53:40 UTC) #2

On 2013/05/15 07:45:21, dak wrote:
> 
>
https://codereview.appspot.com/9239046/diff/1/scm/music-functions.scm#oldcode...
> scm/music-functions.scm:1947: (map (lambda (st)
> That's a case for for-each, not map.

Probably so, but I think changing it with this unrelated change complicates the
history more than it would improve the clarity.

Expand All Messages | Collapse All Messages