code review 9239045: cmd/ld: supply -s to gcc if -s is passed.

cmd/ld: supply -s to gcc if -s is passed.
Fixes issue 5463.

[minux1, 2013-06-07 15:55:06]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2013-06-07 18:02:47]

I can't help but notice that the -s option is not documented in ld/doc.go.

https://codereview.appspot.com/9239045/diff/10001/src/cmd/ld/elf.c
File src/cmd/ld/elf.c (right):

https://codereview.appspot.com/9239045/diff/10001/src/cmd/ld/elf.c#newcode17
src/cmd/ld/elf.c:17: extern int debug_s; // defined in lib.c, backup old value
of debug['s']
I'd rather put this in lib.h, with the EXTERN names.

[minux1, 2013-06-08 06:42:50]

PTAL.

On 2013/06/07 18:02:47, iant wrote:
> I can't help but notice that the -s option is not documented in ld/doc.go.
it's mentioned in http://golang.org/doc/gdb
should we also add it to cmd/ld/doc.go?

> https://codereview.appspot.com/9239045/diff/10001/src/cmd/ld/elf.c#newcode17
> src/cmd/ld/elf.c:17: extern int debug_s; // defined in lib.c, backup old value
> of debug['s']
> I'd rather put this in lib.h, with the EXTERN names.
Done.

[iant, 2013-06-10 17:34:28]

LGTM

On 2013/06/08 06:42:50, minux wrote:
> 
> On 2013/06/07 18:02:47, iant wrote:
> > I can't help but notice that the -s option is not documented in ld/doc.go.
> it's mentioned in http://golang.org/doc/gdb
> should we also add it to cmd/ld/doc.go?

I think we should, but it doesn't have to be in this CL.

Thanks.

Ian

[minux1, 2013-06-11 22:57:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=8f6f14dfd222 ***

cmd/ld: supply -s to gcc if -s is passed.
Fixes issue 5463.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/9239045