Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5379)

Issue 9216043: Remove many (all?) test visual artifacts

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by bcsaller
Modified:
10 years, 11 months ago
Reviewers:
mp+162551, bac, gary.poster
Visibility:
Public.

Description

Remove many (all?) test visual artifacts Use utils.makeContainer many more places. Update some components that render directly to body to take optional target and use that in tests. https://code.launchpad.net/~bcsaller/juju-gui/containagedon/+merge/162551 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove many (all?) test visual artifacts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -124 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/charm-panel.js View 1 chunk +1 line, -1 line 0 comments Download
M test/index.html View 1 1 chunk +1 line, -1 line 0 comments Download
M test/test_app.js View 2 chunks +2 lines, -3 lines 0 comments Download
M test/test_app_hotkeys.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/test_application_notifications.js View 1 chunk +2 lines, -4 lines 0 comments Download
M test/test_browser_app.js View 9 chunks +23 lines, -17 lines 0 comments Download
M test/test_browser_charm_details.js View 4 chunks +9 lines, -7 lines 0 comments Download
M test/test_browser_editorial.js View 3 chunks +10 lines, -7 lines 0 comments Download
M test/test_browser_search_view.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_browser_search_widget.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_charm_collection_view.js View 2 chunks +4 lines, -2 lines 0 comments Download
M test/test_charm_configuration.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test_charm_container.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_charm_panel.js View 7 chunks +34 lines, -29 lines 0 comments Download
M test/test_d3_components.js View 2 chunks +6 lines, -4 lines 0 comments Download
M test/test_filter_widget.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/test_login.js View 1 2 chunks +3 lines, -4 lines 0 comments Download
M test/test_notifier_widget.js View 1 chunk +7 lines, -6 lines 0 comments Download
M test/test_overlay_indicator.js View 1 chunk +7 lines, -7 lines 0 comments Download
M test/test_prettify.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/test_resizing_textarea.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_tabview.js View 1 chunk +4 lines, -3 lines 0 comments Download
M test/test_topology.js View 2 chunks +9 lines, -9 lines 0 comments Download
M test/test_topology_relation.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 6
bcsaller
Please take a look.
10 years, 11 months ago (2013-05-06 01:02:53 UTC) #1
gary.poster
Appspot diff is bad. I looked at it on LP. LGTM! Thanks for cleanups. Looks ...
10 years, 11 months ago (2013-05-06 03:34:07 UTC) #2
bcsaller
Thanks for the review, I removed the mask comment. The diff here looks ok to ...
10 years, 11 months ago (2013-05-06 03:36:36 UTC) #3
bac
LGTM but please fix the indentation in index.html. FWIW the diff is broken for me ...
10 years, 11 months ago (2013-05-06 12:43:51 UTC) #4
bcsaller
Thanks for review, fixed index as asked.
10 years, 11 months ago (2013-05-06 14:28:31 UTC) #5
bcsaller
10 years, 11 months ago (2013-05-06 14:33:41 UTC) #6
*** Submitted:

Remove many (all?) test visual artifacts

Use utils.makeContainer many more places.
Update some components that render directly to body to take 
optional target and use that in tests.

R=gary.poster, bac
CC=
https://codereview.appspot.com/9216043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b