Find an appropriate machine image.

Find an appropriate machine image.

Use 'nova image-list' to find the latest released
Ubuntu amd64 image.  Assumes the list returned
is ordered, though getting the latest isn't
absolutely required.

If a file $HOME/.juju/environments.yaml.template is found,
populate it with the found machine id.  If not found, do nothing.

https://code.launchpad.net/~bac/juju-gui/ci-fix/+merge/164029

(do not edit description out of merge proposal)

[bac, 2013-05-15 20:46:37]

Please take a look.

[jeff.pihach, 2013-05-15 21:50:57]

Thanks for doing this - it's a great improvement. 

Before landing I'd like to see the changes mentioned below.

https://codereview.appspot.com/9207049/diff/1/bin/find-latest-image.sh
File bin/find-latest-image.sh (right):

https://codereview.appspot.com/9207049/diff/1/bin/find-latest-image.sh#newcode2
bin/find-latest-image.sh:2: nova --no-cache image-list |grep
ubuntu-precise-12.04-amd64-server |tail -1 |awk '{print $2}'
I wonder if this should source the nova credentials before the query just in
case the system doesn't do it on bashrc

https://codereview.appspot.com/9207049/diff/1/docs/continuous-integration.rst
File docs/continuous-integration.rst (right):

https://codereview.appspot.com/9207049/diff/1/docs/continuous-integration.rst...
docs/continuous-integration.rst:70: The template has one slot, which is
populated with the most current machine
Curious if another approach would be to modify the original environments.yaml
file and then save a backup.

https://codereview.appspot.com/9207049/diff/1/docs/continuous-integration.rst...
docs/continuous-integration.rst:165: 
I'd also like to see a section on the steps to take if you want to change the
server image used - files to make the changes in, etc.

https://codereview.appspot.com/9207049/diff/1/lib/deploy_charm_for_testing.py
File lib/deploy_charm_for_testing.py (right):

https://codereview.appspot.com/9207049/diff/1/lib/deploy_charm_for_testing.py...
lib/deploy_charm_for_testing.py:104: img_regex = re.compile(
I wonder if we shouldn't be keeping a backup of the current environments.yaml
JIC

https://codereview.appspot.com/9207049/diff/1/test/browser.py
File test/browser.py (right):

https://codereview.appspot.com/9207049/diff/1/test/browser.py#newcode111
test/browser.py:111: print(response.read())
Great idea to add more details to these errors.

https://codereview.appspot.com/9207049/diff/1/test/test_deploy_charm_for_test...
File test/test_deploy_charm_for_testing.py (right):

https://codereview.appspot.com/9207049/diff/1/test/test_deploy_charm_for_test...
test/test_deploy_charm_for_testing.py:152: """Test the image data parsing."""
maybe change this to 'server image' just to avoid some confusion that it's not a
picture

[bac, 2013-05-16 12:51:11]

Please take a look.

https://codereview.appspot.com/9207049/diff/1/bin/find-latest-image.sh
File bin/find-latest-image.sh (right):

https://codereview.appspot.com/9207049/diff/1/bin/find-latest-image.sh#newcode2
bin/find-latest-image.sh:2: nova --no-cache image-list |grep
ubuntu-precise-12.04-amd64-server |tail -1 |awk '{print $2}'
good idea.
done

https://codereview.appspot.com/9207049/diff/1/docs/continuous-integration.rst
File docs/continuous-integration.rst (right):

https://codereview.appspot.com/9207049/diff/1/docs/continuous-integration.rst...
docs/continuous-integration.rst:70: The template has one slot, which is
populated with the most current machine
Yes, that is certainly another approach.  I like the existence of a template
file as a sentinel as to whether to take any action since this script gets run
in different environments and could be triggered by our tests.

https://codereview.appspot.com/9207049/diff/1/lib/deploy_charm_for_testing.py
File lib/deploy_charm_for_testing.py (right):

https://codereview.appspot.com/9207049/diff/1/lib/deploy_charm_for_testing.py...
lib/deploy_charm_for_testing.py:104: img_regex = re.compile(
I rejected that idea as overly complicated and protected by the sentinel of the
template file.  We can discuss if you feel strongly.

https://codereview.appspot.com/9207049/diff/1/test/test_deploy_charm_for_test...
File test/test_deploy_charm_for_testing.py (right):

https://codereview.appspot.com/9207049/diff/1/test/test_deploy_charm_for_test...
test/test_deploy_charm_for_testing.py:152: """Test the image data parsing."""
On 2013/05/15 21:50:57, jeff.pihach wrote:
> maybe change this to 'server image' just to avoid some confusion that it's not
a
> picture

Done.

[jeff.pihach, 2013-05-16 14:15:44]

LGTM Thanks for those changes

[gary.poster, 2013-05-16 14:17:49]

LGTM thank you!

https://codereview.appspot.com/9207049/diff/5001/lib/deploy_charm_for_testing.py
File lib/deploy_charm_for_testing.py (right):

https://codereview.appspot.com/9207049/diff/5001/lib/deploy_charm_for_testing...
lib/deploy_charm_for_testing.py:128: # environments.yaml file.
Maybe print a statement saying what you are doing and why?

https://codereview.appspot.com/9207049/diff/5001/test/browser.py
File test/browser.py (right):

https://codereview.appspot.com/9207049/diff/5001/test/browser.py#newcode110
test/browser.py:110: print(response.reason)
Nice improvement

[bac, 2013-05-16 15:52:37]

*** Submitted:

Find an appropriate machine image.

Use 'nova image-list' to find the latest released
Ubuntu amd64 image.  Assumes the list returned
is ordered, though getting the latest isn't
absolutely required.

If a file $HOME/.juju/environments.yaml.template is found,
populate it with the found machine id.  If not found, do nothing.

R=jeff.pihach, gary.poster
CC=
https://codereview.appspot.com/9207049

https://codereview.appspot.com/9207049/diff/5001/lib/deploy_charm_for_testing.py
File lib/deploy_charm_for_testing.py (right):

https://codereview.appspot.com/9207049/diff/5001/lib/deploy_charm_for_testing...
lib/deploy_charm_for_testing.py:128: # environments.yaml file.
On 2013/05/16 14:17:49, gary.poster wrote:
> Maybe print a statement saying what you are doing and why?

Done.