Issue 9204044: CI Fixes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9204044: CI Fixes

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 11 months ago by jeff.pihach

Modified:
10 years, 11 months ago

Reviewers:
mp+162533, benji, gary.poster

Visibility:
Public.

Description

CI Fixes Implements workaround for cross browser textarea height offset issues and removes the shortened timeout on the import tests https://code.launchpad.net/~hatch/juju-gui/ci-fixes/+merge/162533 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : CI Fixes #

Total comments: 1

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	test/test_fakebackend.js	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/test_resizing_textarea.js	View	4 chunks	+8 lines, -6 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

Don't really understand the timeout, but I'll take it for now, assuming Ben will fix ...

10 years, 11 months ago (2013-05-05 17:18:09 UTC) #2

jeff.pihach

*** Submitted: CI Fixes Implements workaround for cross browser textarea height offset issues and removes ...

10 years, 11 months ago (2013-05-05 17:36:34 UTC) #3

benji

10 years, 11 months ago (2013-05-07 21:38:48 UTC) #4

Looks good.  We might want to update the one comment to include Firefox.

LGTM-ly y'rs.

https://codereview.appspot.com/9204044/diff/4001/test/test_resizing_textarea.js
File test/test_resizing_textarea.js (right):

https://codereview.appspot.com/9204044/diff/4001/test/test_resizing_textarea....
test/test_resizing_textarea.js:37: // IE10 Computes sizes wrong.
The comment should be updated to include Firefox.

Expand All Messages | Collapse All Messages