Issue 9196047: code review 9196047: runtime: unset m->locks after actual lock unlock

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9196047: code review 9196047: runtime: unset m->locks after actual lock unlock (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by dvyukov

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, khr, iant

Visibility:
Public.

Description

runtime: unset m->locks after actual lock unlock This is needed for preemptive scheduler, it will preempt only when m->locks==0, and we do not want to be preempted while we have not completely unlocked the lock.

Patch Set 1 #

Patch Set 2 : diff -r d29da2ced72b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d29da2ced72b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r a23a2a12cd36 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/pkg/runtime/lock_futex.c	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
	M	src/pkg/runtime/lock_sema.c	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 2 months ago (2013-05-13 10:04:51 UTC) #1

dvyukov

12 years, 2 months ago (2013-05-15 12:48:58 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=2cb5c773629c ***

runtime: unset m->locks after actual lock unlock
This is needed for preemptive scheduler,
it will preempt only when m->locks==0,
and we do not want to be preempted while
we have not completely unlocked the lock.

R=golang-dev, khr, iant
CC=golang-dev
https://codereview.appspot.com/9196047

Expand All Messages | Collapse All Messages