Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3330)

Issue 91880044: code review 91880044: net/http: remove a duplicated check

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by robryk
Modified:
9 years, 10 months ago
Reviewers:
gobot, rh, bradfitz
CC:
golang-codereviews, rh, bradfitz
Visibility:
Public.

Description

net/http: remove a duplicated check The previous call to parseRange already checks whether all the ranges start before the end of file.

Patch Set 1 #

Patch Set 2 : diff -r 96cbc91bc15a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 96cbc91bc15a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M src/pkg/net/http/fs.go View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7
robryk
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
10 years ago (2014-04-28 05:23:58 UTC) #1
rh
On 2014/04/28 05:23:58, robryk wrote: > Hello mailto:golang-codereviews@googlegroups.com, > > I'd like you to review ...
10 years ago (2014-04-28 12:17:39 UTC) #2
gobot
R=bradfitz@golang.org (assigned by r@golang.org)
10 years ago (2014-04-28 17:19:58 UTC) #3
robryk
Gentle ping. Go 1.3 is out so this should be ok now.
9 years, 10 months ago (2014-06-19 21:52:45 UTC) #4
bradfitz
LGTM
9 years, 10 months ago (2014-06-24 00:37:39 UTC) #5
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=75040398cb4e *** net/http: remove a duplicated check The previous call to parseRange ...
9 years, 10 months ago (2014-06-24 00:38:20 UTC) #6
gobot
9 years, 10 months ago (2014-06-24 01:24:02 UTC) #7
This CL appears to have broken the netbsd-amd64-bsiegert builder.
See http://build.golang.org/log/2d23e413055bb193c082e84785e8adce72376707
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b