Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(111)

Issue 9187047: code review 9187047: crypto/tls: fix flakey test. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 4 months ago by agl1
Modified:
9 years, 4 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

crypto/tls: fix flakey test. A test added in b37d2fdcc4d9 didn't work with some values of GOMAXPROCS because the defer statements were in the wrong order: the Pipe could be closed before the TLS Client was.

Patch Set 1 #

Patch Set 2 : diff -r 1c5529b1592a https://code.google.com/p/go/ #

Patch Set 3 : diff -r 1c5529b1592a https://code.google.com/p/go/ #

Patch Set 4 : diff -r f95d161ca3cb https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/pkg/crypto/tls/handshake_client_test.go View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
9 years, 4 months ago (2013-05-16 16:23:03 UTC) #1
bradfitz
LGTM On May 16, 2013 9:23 AM, <agl@golang.org> wrote: > Reviewers: golang-dev1, > > Message: ...
9 years, 4 months ago (2013-05-16 16:25:19 UTC) #2
agl1
9 years, 4 months ago (2013-05-16 16:29:35 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=e4df8909ab83 ***

crypto/tls: fix flakey test.

A test added in b37d2fdcc4d9 didn't work with some values of GOMAXPROCS
because the defer statements were in the wrong order: the Pipe could be
closed before the TLS Client was.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/9187047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b