Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(273)

Issue 9178043: Merge promise code into trunk

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by jeff.pihach
Modified:
10 years, 12 months ago
Reviewers:
bcsaller, mp+162414
Visibility:
Public.

Description

Merge promise code into trunk This merges the promise code into the trunk and adds a promise store in the model controller to combat a race condition with the multiple dispatch https://code.launchpad.net/~hatch/juju-gui/promise-conflict/+merge/162414 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Merge promise code into trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -189 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 7 chunks +109 lines, -38 lines 0 comments Download
M app/models/model-controller.js View 1 4 chunks +42 lines, -4 lines 0 comments Download
M app/views/service.js View 8 chunks +160 lines, -134 lines 0 comments Download
M test/test_app.js View 1 chunk +1 line, -1 line 0 comments Download
M test/test_endpoints.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test_service_view.js View 2 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 4
jeff.pihach
Please take a look.
10 years, 12 months ago (2013-05-03 16:21:37 UTC) #1
bcsaller
LGTM Seems to hide the race, still too aggressive with the notifications. Add a card ...
10 years, 12 months ago (2013-05-03 16:54:00 UTC) #2
jeff.pihach
Thanks for the review - a card will be created for the notifications https://codereview.appspot.com/9178043/diff/1/app/models/model-controller.js File ...
10 years, 12 months ago (2013-05-03 17:00:23 UTC) #3
jeff.pihach
10 years, 12 months ago (2013-05-03 17:06:34 UTC) #4
*** Submitted:

Merge promise code into trunk

This merges the promise code into the trunk and
adds a promise store in the model controller to 
combat a race condition with the multiple dispatch

R=bcsaller
CC=
https://codereview.appspot.com/9178043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b