code review 9164043: cmd/go: better error for shadowed directories in GOPATH

cmd/go: better error for shadowed directories in GOPATH

Fixes issue 5774.

[rsc, 2013-05-03 13:14:47]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[adg, 2013-05-03 13:29:51]

https://codereview.appspot.com/9164043/diff/2001/src/cmd/go/build.go
File src/cmd/go/build.go (right):

https://codereview.appspot.com/9164043/diff/2001/src/cmd/go/build.go#newcode303
src/cmd/go/build.go:303: errorf("go install: no install location for directory
%s hidden by %s", p.Dir, p.ConflictDir)
should this be "%s: hidden by %s" (with the colon) ? same for the next message

https://codereview.appspot.com/9164043/diff/2001/src/cmd/go/test.bash
File src/cmd/go/test.bash (right):

https://codereview.appspot.com/9164043/diff/2001/src/cmd/go/test.bash#newcode331
src/cmd/go/test.bash:331: export
GOPATH=$(pwd)/testdata/shadow/root1:$(pwd)/testdata/shadow/root2
did you forget to add testdata/shadow? i don't see it in my tree

[r, 2013-06-08 19:29:08]

update?

[adg, 2013-07-23 22:26:33]

Let's get this in for 1.2?

[r, 2013-08-06 23:28:32]

ping

[rsc, 2013-08-13 20:17:53]

I'll get to this at some point. It's fairly low on my list.

[rsc, 2013-09-10 17:01:11]

Hello golang-dev@googlegroups.com, adg@golang.org, r@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-09-10 17:15:24]

LGTM
 On Sep 10, 2013 10:01 AM, <rsc@golang.org> wrote:

> Hello golang-dev@googlegroups.com, adg@golang.org, r@golang.org (cc:
> golang-dev@googlegroups.com),
>
> Please take another look.
>
>
>
https://codereview.appspot.**com/9164043/<https://codereview.appspot.com/9164...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>

[rsc, 2013-09-10 17:17:25]

*** Submitted as https://code.google.com/p/go/source/detail?r=2d673b7f9c9e ***

cmd/go: better error for shadowed directories in GOPATH

Fixes issue 5774.

R=golang-dev, adg, r, bradfitz
CC=golang-dev
https://codereview.appspot.com/9164043