rsyslog: ensure logs accumulate on state machines

rsyslog: ensure logs accumulate on state machines

Added a WatchForRsyslogChanges watcher and extended the API with
GetRsyslogConfig. Changed the rsyslog worker to use these additions.

https://code.launchpad.net/~mfoord/juju-core/ha-rsyslog-good/+merge/220669

(do not edit description out of merge proposal)

[mfoord, 2014-05-22 15:28:16]

Please take a look.

[mfoord, 2014-05-22 15:31:10]

This CL supercedes 94510043

https://codereview.appspot.com/94510043/

It also implements the review comments below.

On 2014/05/22 10:57:40, mfoord wrote:
> On 2014/05/21 08:06:30, fwereade wrote:
> > Last few changes, otherwise looking good. Thanks.
> > 
> >
https://codereview.appspot.com/94510043/diff/40001/state/api/params/params.go
> > File state/api/params/params.go (right):
> > 
> >
>
https://codereview.appspot.com/94510043/diff/40001/state/api/params/params.go...
> > state/api/params/params.go:687: Port      int
> > please document that Port is just there for compatibility, and capable
clients
> > should trust the HostPorts.
> > 
> 
> The Port is there for state servers to know which port to listen on. It isn't
> used by units. I've added a note to this effect.
> 
> >
>
https://codereview.appspot.com/94510043/diff/40001/state/api/rsyslog/rsyslog.go
> > File state/api/rsyslog/rsyslog.go (right):
> > 
> >
>
https://codereview.appspot.com/94510043/diff/40001/state/api/rsyslog/rsyslog....
> > state/api/rsyslog/rsyslog.go:20: Port      int
> > I think you can completely drop Port from this one, right?
> > 
> 
> As discussed we can't drop this until state servers have a mechanism for
picking
> a port and storing it in the state, so that GetRsyslogConfig can then return
the
> right information in HostPorts. I've added a note that the Port is only for
> state servers to know which port to listen on.
> 
> >
>
https://codereview.appspot.com/94510043/diff/40001/state/apiserver/rsyslog/rs...
> > File state/apiserver/rsyslog/rsyslog.go (left):
> > 
> >
>
https://codereview.appspot.com/94510043/diff/40001/state/apiserver/rsyslog/rs...
> > state/apiserver/rsyslog/rsyslog.go:33: func (api *RsyslogAPI)
> > SetRsyslogCert(args params.SetRsyslogCertParams) (params.ErrorResult, error)
{
> > This still bugs me but it's not actionable right now.
> > 
> 
> Right.
> 
> >
>
https://codereview.appspot.com/94510043/diff/40001/state/apiserver/rsyslog/rs...
> > File state/apiserver/rsyslog/rsyslog.go (right):
> > 
> >
>
https://codereview.appspot.com/94510043/diff/40001/state/apiserver/rsyslog/rs...
> > state/apiserver/rsyslog/rsyslog.go:27: if !authorizer.AuthMachineAgent() &&
> > !authorizer.AuthUnitAgent() {
> > do we have an AuthAgent? maybe we should
> > 
> 
> We don't. Adding it was more trouble that it was worth for a single use case.
> John is working on making srvRoot more testable, so if we see another use case
> for this method it can be added then.
> 
> >
>
https://codereview.appspot.com/94510043/diff/40001/state/apiserver/rsyslog/rs...
> > state/apiserver/rsyslog/rsyslog.go:63: func (api *RsyslogAPI)
> GetRsyslogConfig()
> > (params.RsyslogConfigResult, error) {
> > Heh, almost missed this. Please make it bulky, like WatchForRsyslogChanges
> > below; I can't see when we'll need it but I'd prefer to remain consistent.
> 
> Ok, working on this. Also some test failures I see with the current state of
> this branch.

[fwereade, 2014-05-26 13:05:36]

LGTM