Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(161)

Issue 91610046: code review 91610046: cmd/go: fix coverage for 'package foo_test' tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rsc
Modified:
11 years, 7 months ago
Reviewers:
r
CC:
r, golang-codereviews
Visibility:
Public.

Description

cmd/go: fix coverage for 'package foo_test' tests Fixes issue 8062.

Patch Set 1 #

Patch Set 2 : diff -r fac90a291326 https://code.google.com/p/go/ #

Patch Set 3 : diff -r fac90a291326 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 770b33dcf873 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -38 lines) Patch
M src/cmd/go/test.bash View 1 2 chunks +22 lines, -14 lines 0 comments Download
M src/cmd/go/test.go View 1 3 chunks +32 lines, -24 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 7 months ago (2014-05-21 16:08:34 UTC) #1
r
LGTM https://codereview.appspot.com/91610046/diff/40001/src/cmd/go/test.bash File src/cmd/go/test.bash (right): https://codereview.appspot.com/91610046/diff/40001/src/cmd/go/test.bash#newcode568 src/cmd/go/test.bash:568: if grep '[^0-9]0\.0%' testdata/cover.txt >/dev/null; then grep -q ...
11 years, 7 months ago (2014-05-21 16:20:13 UTC) #2
rsc
On Wed, May 21, 2014 at 12:20 PM, <r@golang.org> wrote: > https://codereview.appspot.com/91610046/diff/40001/src/ > cmd/go/test.bash#newcode568 > ...
11 years, 7 months ago (2014-05-21 17:58:47 UTC) #3
rsc
11 years, 7 months ago (2014-05-21 17:59:17 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=6722015c5074 ***

cmd/go: fix coverage for 'package foo_test' tests

Fixes issue 8062.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/91610046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b