Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1889)

Issue 91590044: code review 91590044: doc/go1.3.html: mention cgo [0]byte bug fix fallout (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 4 months ago by rsc
Modified:
5 years, 4 months ago
Reviewers:
r
CC:
r, golang-codereviews
Visibility:
Public.

Description

doc/go1.3.html: mention cgo [0]byte bug fix fallout Fixes issue 7958.

Patch Set 1 #

Patch Set 2 : diff -r 29348a1c6914 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 29348a1c6914 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 4 : diff -r 29348a1c6914 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 5 : diff -r 29348a1c6914 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -20 lines) Patch
M doc/go1.3.html View 1 2 3 4 13 chunks +53 lines, -20 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
5 years, 4 months ago (2014-05-20 16:26:37 UTC) #1
r
https://codereview.appspot.com/91590044/diff/40001/doc/go1.3.html File doc/go1.3.html (right): https://codereview.appspot.com/91590044/diff/40001/doc/go1.3.html#newcode249 doc/go1.3.html:249: to a function expecting another. Go 1.3 corrects this ...
5 years, 4 months ago (2014-05-20 16:46:13 UTC) #2
rsc
PTAL https://codereview.appspot.com/91590044/diff/40001/doc/go1.3.html File doc/go1.3.html (right): https://codereview.appspot.com/91590044/diff/40001/doc/go1.3.html#newcode249 doc/go1.3.html:249: to a function expecting another. Go 1.3 corrects ...
5 years, 4 months ago (2014-05-20 16:53:58 UTC) #3
r
LGTM https://codereview.appspot.com/91590044/diff/50001/doc/go1.3.html File doc/go1.3.html (right): https://codereview.appspot.com/91590044/diff/50001/doc/go1.3.html#newcode253 doc/go1.3.html:253: from one package to another. This is not ...
5 years, 4 months ago (2014-05-20 16:57:56 UTC) #4
rsc
https://codereview.appspot.com/91590044/diff/50001/doc/go1.3.html File doc/go1.3.html (right): https://codereview.appspot.com/91590044/diff/50001/doc/go1.3.html#newcode253 doc/go1.3.html:253: from one package to another. This is not legal ...
5 years, 4 months ago (2014-05-20 17:38:31 UTC) #5
rsc
5 years, 4 months ago (2014-05-20 17:38:46 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=1cce51e90726 ***

doc/go1.3.html: mention cgo [0]byte bug fix fallout

Fixes issue 7958.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/91590044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b