Issue 91580043: constraints: fix lp 1320738

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 91580043: constraints: fix lp 1320738

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by dave

Modified:
10 years ago

Reviewers:
mp+220156, fwereade

Visibility:
Public.

Description

constraints: fix lp 1320738 Fixes lp 1320738 Although the red and blue constraints sets are sets, for consistency sort them before looking for the intersection to return predictable error messages. For no particular reason constraints will be sorted by name. https://code.launchpad.net/~dave-cheney/juju-core/172-fix-constraints-test-failure/+merge/220156 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : constraints: fix lp 1320738 #

Patch Set 3 : constraints: fix lp 1320738 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -14 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/bootstrap_test.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	constraints/validation.go	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	constraints/validation_test.go	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	state/machine_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	state/service_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	state/state_test.go	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Please take a look.

Expand All Messages | Collapse All Messages