Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 91520043: code review 91520043: cmd/cgo: document the cgo types also follow Go name spa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 6 months ago by minux1
Modified:
5 years, 5 months ago
Reviewers:
gobot, minux, rsc
CC:
golang-codereviews, rsc, r
Visibility:
Public.

Description

cmd/cgo: document the cgo types also follow Go name space rules. Fixes issue 7958.

Patch Set 1 #

Patch Set 2 : diff -r 386c6757d94c https://code.google.com/p/go #

Patch Set 3 : diff -r 386c6757d94c https://code.google.com/p/go #

Patch Set 4 : diff -r 386c6757d94c https://code.google.com/p/go #

Patch Set 5 : diff -r 386c6757d94c https://code.google.com/p/go #

Patch Set 6 : diff -r 2cd1027581fa https://code.google.com/p/go #

Total comments: 3

Patch Set 7 : diff -r 4a42f01fe42f https://code.google.com/p/go #

Patch Set 8 : diff -r 4a42f01fe42f https://code.google.com/p/go #

Total comments: 2

Patch Set 9 : diff -r 4a42f01fe42f https://code.google.com/p/go #

Patch Set 10 : diff -r 708e129e91a9 https://code.google.com/p/go #

Total comments: 2

Patch Set 11 : diff -r 46d573d68ee6 https://code.google.com/p/go #

Patch Set 12 : diff -r 46d573d68ee6 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/cmd/cgo/doc.go View 1 2 3 4 5 6 7 8 9 10 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12
minux1
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
5 years, 6 months ago (2014-05-17 21:10:04 UTC) #1
minux1
we probably can also document issue 7786 as known bug of cgo here.
5 years, 6 months ago (2014-05-17 21:14:20 UTC) #2
r
https://codereview.appspot.com/91520043/diff/80001/doc/go1.3.html File doc/go1.3.html (right): https://codereview.appspot.com/91520043/diff/80001/doc/go1.3.html#newcode246 doc/go1.3.html:246: corresponding C types are different. Before Go 1.3, cgo ...
5 years, 6 months ago (2014-05-19 16:47:05 UTC) #3
minux1
PTAL. Russ have already made changes to the release docs, so this CL will focus ...
5 years, 6 months ago (2014-05-20 18:49:43 UTC) #4
r
leaving for rsc https://codereview.appspot.com/91520043/diff/120001/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): https://codereview.appspot.com/91520043/diff/120001/src/cmd/cgo/doc.go#newcode108 src/cmd/cgo/doc.go:108: Opaque types in C (such as ...
5 years, 6 months ago (2014-05-20 18:59:55 UTC) #5
minux1
PTAL. https://codereview.appspot.com/91520043/diff/120001/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): https://codereview.appspot.com/91520043/diff/120001/src/cmd/cgo/doc.go#newcode108 src/cmd/cgo/doc.go:108: Opaque types in C (such as void* or ...
5 years, 6 months ago (2014-05-20 19:08:58 UTC) #6
minux1
Gentle ping. Russ?
5 years, 6 months ago (2014-05-22 00:19:17 UTC) #7
gobot
R=rsc@golang.org (assigned by r@golang.org)
5 years, 5 months ago (2014-05-29 21:29:36 UTC) #8
rsc
LGTM https://codereview.appspot.com/91520043/diff/160001/src/cmd/cgo/doc.go File src/cmd/cgo/doc.go (right): https://codereview.appspot.com/91520043/diff/160001/src/cmd/cgo/doc.go#newcode110 src/cmd/cgo/doc.go:110: Cgo translates C types into their equivalent Go ...
5 years, 5 months ago (2014-05-30 21:08:15 UTC) #9
minux1
*** Submitted as https://code.google.com/p/go/source/detail?r=78cda70d487e *** cmd/cgo: document the cgo types also follow Go name space ...
5 years, 5 months ago (2014-05-31 07:51:51 UTC) #10
gobot
This CL appears to have broken the plan9-386-cnielsen builder. See http://build.golang.org/log/327e716d60c0f250b9a103832a961348cf2e27c2
5 years, 5 months ago (2014-05-31 08:01:56 UTC) #11
minux
5 years, 5 months ago (2014-05-31 08:13:04 UTC) #12
On Sat, May 31, 2014 at 1:01 AM, <gobot@golang.org> wrote:

> This CL appears to have broken the plan9-386-cnielsen builder.
> See http://build.golang.org/log/327e716d60c0f250b9a103832a961348cf2e27c2

--- FAIL: TestResponseWriterWriteStringAllocs (0.00 seconds)
 serve_test.go:2292: WriteString allocs of 21 >= Write allocs of 21
FAIL
FAIL net/http 19.196s

it seems testing.AllocPerRun tests are still flaky.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b