Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(258)

Issue 91500046: code review 91500046: cmd/ld: abort if (32-bit) address relocation is negativ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by minux1
Modified:
7 years, 12 months ago
Reviewers:
rsc, dfc, iant, josharian
CC:
iant, dfc, josharian, golang-codereviews
Visibility:
Public.

Description

cmd/ld: abort if (32-bit) address relocation is negative on amd64. Update issue 7980 This CL make the linker abort for the example program. For Go 1.4, we need to find a general way to handle large memory model programs.

Patch Set 1 #

Patch Set 2 : diff -r 3458ba248590 https://code.google.com/p/go #

Patch Set 3 : diff -r 3458ba248590 https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r 43fdb7e80241 https://code.google.com/p/go #

Patch Set 5 : diff -r 43fdb7e80241 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/cmd/ld/data.c View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12
minux1
Hello iant@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
8 years ago (2014-05-15 23:20:14 UTC) #1
dfc
LGTM. I think this is a reasonable way to ensure we don't generate broken programs. ...
8 years ago (2014-05-15 23:38:01 UTC) #2
josharian
LGTM, at least for 1.3 Thanks, minux. https://codereview.appspot.com/91500046/diff/40001/src/cmd/ld/data.c File src/cmd/ld/data.c (right): https://codereview.appspot.com/91500046/diff/40001/src/cmd/ld/data.c#newcode251 src/cmd/ld/data.c:251: diag("non-pc-relative relocation ...
8 years ago (2014-05-15 23:53:25 UTC) #3
iant
https://codereview.appspot.com/91500046/diff/40001/src/cmd/ld/data.c File src/cmd/ld/data.c (right): https://codereview.appspot.com/91500046/diff/40001/src/cmd/ld/data.c#newcode250 src/cmd/ld/data.c:250: if((int32)o < 0 && thechar == '6') I think ...
8 years ago (2014-05-15 23:53:45 UTC) #4
minux1
Hello iant@golang.org, dave@cheney.net, josharian@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
8 years ago (2014-05-16 00:06:57 UTC) #5
minux1
On May 15, 2014 7:53 PM, <josharian@gmail.com> wrote: > https://codereview.appspot.com/91500046/diff/40001/src/cmd/ld/data.c > File src/cmd/ld/data.c (right): > ...
8 years ago (2014-05-16 00:08:09 UTC) #6
josharian
> src/cmd/ld/data.c:250: if((int32)o < 0 && thechar == '6') > I think we can future-proof ...
8 years ago (2014-05-16 00:08:42 UTC) #7
minux1
On May 15, 2014 7:53 PM, <iant@golang.org> wrote: > https://codereview.appspot.com/91500046/diff/40001/src/cmd/ld/data.c > File src/cmd/ld/data.c (right): > ...
8 years ago (2014-05-16 00:13:03 UTC) #8
iant
On Thu, May 15, 2014 at 5:08 PM, <josharian@gmail.com> wrote: >> src/cmd/ld/data.c:250: if((int32)o < 0 ...
8 years ago (2014-05-16 00:39:06 UTC) #9
iant
LGTM
8 years ago (2014-05-16 00:39:30 UTC) #10
josharian
> >> src/cmd/ld/data.c:250: if((int32)o < 0 && thechar == '6') > >> I think we ...
8 years ago (2014-05-16 00:50:47 UTC) #11
rsc
8 years ago (2014-05-20 02:39:44 UTC) #12
*** Submitted as https://code.google.com/p/go/source/detail?r=793272b5aeef ***

cmd/ld: abort if (32-bit) address relocation is negative on amd64.
Update issue 7980
This CL make the linker abort for the example program. For Go 1.4,
we need to find a general way to handle large memory model programs.

LGTM=dave, josharian, iant
R=iant, dave, josharian
CC=golang-codereviews
https://codereview.appspot.com/91500046

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b