Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5066)

Issue 9145044: code review 9145044: doc: Fix typo in approximation of square root (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by kytrinyx
Modified:
10 years, 11 months ago
Reviewers:
adg
CC:
golang-dev, minux1, adg
Visibility:
Public.

Description

doc: Fix typo in approximation of square root See https://en.wikipedia.org/wiki/Newton%27s_method#Square_root_of_a_number

Patch Set 1 #

Patch Set 2 : diff -r 740d244b2047 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 740d244b2047 https://code.google.com/p/go/ #

Total comments: 3

Patch Set 4 : diff -r 740d244b2047 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 740d244b2047 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M doc/code.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
kytrinyx
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years ago (2013-05-03 04:21:31 UTC) #1
minux1
https://codereview.appspot.com/9145044/diff/4001/doc/code.html File doc/code.html (right): https://codereview.appspot.com/9145044/diff/4001/doc/code.html#newcode300 doc/code.html:300: z -= (z*z - x) / (2 * z) ...
11 years ago (2013-05-03 08:22:53 UTC) #2
adg
Thanks (after making the changes, please run 'hg mail' again) https://codereview.appspot.com/9145044/diff/4001/doc/code.html File doc/code.html (right): https://codereview.appspot.com/9145044/diff/4001/doc/code.html#newcode298 ...
11 years ago (2013-05-03 13:21:07 UTC) #3
kytrinyx
Hello golang-dev@googlegroups.com, minux.ma@gmail.com, adg@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years ago (2013-05-03 14:49:50 UTC) #4
adg
LGTM The final step is to sign the CLA, described here: http://golang.org/doc/contribute.html#Copyright Thanks!
11 years ago (2013-05-03 14:55:58 UTC) #5
adg
10 years, 11 months ago (2013-05-29 03:49:58 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=1a042de45e20 ***

doc: Fix typo in approximation of square root

See https://en.wikipedia.org/wiki/Newton%27s_method#Square_root_of_a_number

R=golang-dev, minux.ma, adg
CC=golang-dev
https://codereview.appspot.com/9145044

Committer: Andrew Gerrand <adg@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b