Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1096)

Issue 9125043: Fix import errors in stop hook.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 12 months ago by frankban
Modified:
10 years, 12 months ago
Reviewers:
mp+162149, teknico, gary.poster
Visibility:
Public.

Description

Fix import errors in stop hook. This branch includes three trivial fixes: - stop hook not working; - using https://manage.jujucharms.com as charmworld URL by default; - no need to provide credentials in sandbox mode. https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1171490-stop-hook/+merge/162149 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix import errors in stop hook. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M config.yaml View 1 chunk +1 line, -1 line 0 comments Download
M hooks/stop View 1 1 chunk +0 lines, -1 line 0 comments Download
M hooks/utils.py View 1 3 chunks +3 lines, -2 lines 0 comments Download
M revision View 1 chunk +1 line, -1 line 0 comments Download
M tests/test_utils.py View 1 5 chunks +17 lines, -4 lines 0 comments Download

Messages

Total messages: 5
frankban
Please take a look.
10 years, 12 months ago (2013-05-02 16:31:26 UTC) #1
teknico
LGTM, nice fixes and test.
10 years, 12 months ago (2013-05-02 17:04:43 UTC) #2
gary.poster
LGTM, thank you!
10 years, 12 months ago (2013-05-02 17:22:49 UTC) #3
frankban
*** Submitted: Fix import errors in stop hook. This branch includes three trivial fixes: - ...
10 years, 12 months ago (2013-05-03 10:33:47 UTC) #4
frankban
10 years, 12 months ago (2013-05-03 11:02:07 UTC) #5
Thanks for the reviews, Gary and Nicola!
Merged trunk, deploy tests passed two times in a row.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b