Issue 91250043: code review 91250043: cmd/addr2line: accept optional "0x" prefix for addresses.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 91250043: code review 91250043: cmd/addr2line: accept optional "0x" prefix for addresses. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by minux1

Modified:
10 years, 12 months ago

Reviewers:
rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/addr2line: accept optional "0x" prefix for addresses.

Patch Set 1 #

Patch Set 2 : diff -r e3d533e55750 https://code.google.com/p/go #

Patch Set 3 : diff -r 30b1c2ff7d93 https://code.google.com/p/go #

Patch Set 4 : diff -r 30b1c2ff7d93 https://code.google.com/p/go #

Patch Set 5 : diff -r 30b1c2ff7d93 https://code.google.com/p/go #

Created: 10 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/cmd/addr2line/main.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

10 years, 12 months ago (2014-05-10 17:35:32 UTC) #2

minux1

10 years, 12 months ago (2014-05-10 17:35:45 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=117e2da7696d ***

cmd/addr2line: accept optional "0x" prefix for addresses.

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/91250043

Expand All Messages | Collapse All Messages