Wire up resizingTextarea

Wire up resizingTextarea

Added to charm panel and to service config view.

https://code.launchpad.net/~bac/juju-gui/hookup-resizing-textarea/+merge/162119

(do not edit description out of merge proposal)

[bac, 2013-05-02 15:45:28]

Please take a look.

[jovan.ljubojevic, 2013-05-02 16:31:54]

On 2013/05/02 15:45:28, bac wrote:
> Please take a look.

It works well, apart from the text bouncing when I press Enter. It doesn't
bounce in the opposite direction, i.e. when I press Backspace. A slight niggle,
but it would be good if it could be fixed.

[matthew.scott, 2013-05-02 16:32:58]

LGTM, QA'd fine.  Thanks for the branch!

https://codereview.appspot.com/9122043/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/9122043/diff/1/app/app.js#newcode539
app/app.js:539: // If the view contains a method call fitToWindow,
"// If the view contains methods called attachPlugins or fitToWindow..." maybe?

[gary.poster, 2013-05-02 17:16:16]

LGTM with response to below.  Thank you very much!  Yay!

Gary

https://codereview.appspot.com/9122043/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/9122043/diff/1/app/app.js#newcode539
app/app.js:539: // If the view contains a method call fitToWindow,
add mention of attachPlugins?  Maybe describe what the functions are expected to
do?

https://codereview.appspot.com/9122043/diff/1/app/assets/javascripts/resizing...
File app/assets/javascripts/resizing_textarea.js (right):

https://codereview.appspot.com/9122043/diff/1/app/assets/javascripts/resizing...
app/assets/javascripts/resizing_textarea.js:149: clone_one.remove(true);
Nice improvement

https://codereview.appspot.com/9122043/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/9122043/diff/1/app/views/service.js#newcode739
app/views/service.js:739: attachPlugins: function() {
Why can't we do this in render, the way you do it elsewhere?

https://codereview.appspot.com/9122043/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/9122043/diff/1/app/views/utils.js#newcode651
app/views/utils.js:651: entry.value = value.trimRight();
Hm.  How do we know this is not lossy?  What if the whitespace is significant? 
Seems unlikely but not impossible.  I'm guessing you added this because we
needed it though.  Do any other compromises come to mind that might be less
potentially lossy?  Examples:  we only do this if the value is a single line? 
In that case, we only remove the newline?

[bac, 2013-05-02 18:20:15]

Jovan I've discussed some possible solutions to this problem and the one that
we've come up with requires changing the default size.  Rather than muck with
the visual design of the charm panel that we worked so hard to get right, I'm
going to defer a solution until later.

[bac, 2013-05-02 19:48:41]

*** Submitted:

Wire up resizingTextarea

Added to charm panel and to service config view.

R=jovan.ljubojevic, matthew.scott, gary.poster
CC=
https://codereview.appspot.com/9122043

https://codereview.appspot.com/9122043/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/9122043/diff/1/app/app.js#newcode539
app/app.js:539: // If the view contains a method call fitToWindow,
On 2013/05/02 16:32:58, matthew.scott wrote:
> "// If the view contains methods called attachPlugins or fitToWindow..."
maybe?

Done.

https://codereview.appspot.com/9122043/diff/1/app/views/service.js
File app/views/service.js (right):

https://codereview.appspot.com/9122043/diff/1/app/views/service.js#newcode739
app/views/service.js:739: attachPlugins: function() {
On 2013/05/02 17:16:17, gary.poster wrote:
> Why can't we do this in render, the way you do it elsewhere?

Good question, partially answered in the comment above.  In the charm panel, the
container has already been added to the DOM when render is called.  In the
service config view it has not and so all of the size queries we do return 0 ...
things not in the DOM have no size.

So that's why it is here.

https://codereview.appspot.com/9122043/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/9122043/diff/1/app/views/utils.js#newcode651
app/views/utils.js:651: entry.value = value.trimRight();
I've removed the trimRight. It was left over from attempting to solve a problem
that was fixed in another approach.