DescriptionAdd more unit tests to the charm backend.
More unit tests for backend properties, commands and methods.
In order to do that, it mangles the charm code pretty heavily:
- it adds module prefixes to all functions imported by backend.py in order to
make them monkeypatchable in tests;
- it renames all sub-backends to mixins, for clarity. Arguably, "backend.mixins
lists all active mixins" is clearer than "backend.backends lists all active
sub-backends, some of which are actual backends and some others are mixins";
- it simplifies the code in a number of places;
- it removes unused or scarcely used code in backend.py, for simplicity;
- it rephrases some docstrings in more specific terms, for readability;
- it removes the overrideable testing framework in backend.py. It imposes a
runtime and complexity cost for doing what is already done in other tests by
monkeypatching;
Further style changes have been moved to a subsequent branch.
It also fixes two import errors.
WARNING: this branch did successfully deploy a stable juju-gui release.
Deploy tests did not run successfully though, and they seem to be broken
in trunk too, right now.
https://code.launchpad.net/~teknico/charms/precise/juju-gui/1171516-more-backend-tests/+merge/162106
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 34
Patch Set 2 : Add more unit tests to the charm backend. #
MessagesTotal messages: 9
|