Issue 9120045: code review 9120045: cmd/cgo: pass -Wsystem-headers when looking for errors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9120045: code review 9120045: cmd/cgo: pass -Wsystem-headers when looking for errors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by iant

Modified:
11 years, 10 months ago

Reviewers:

CC:
golang-dev, r, minux1

Visibility:
Public.

Description

cmd/cgo: pass -Wsystem-headers when looking for errors This works around a bug in GCC 4.8.0. Fixes issue 5118.

Patch Set 1 #

Patch Set 2 : diff -r f1ddc3ce3dfe https://code.google.com/p/go #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	src/cmd/cgo/gcc.go	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 10 months ago (2013-05-08 03:32:17 UTC) #1

iant

11 years, 10 months ago (2013-05-08 13:28:48 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=e4f62df3e6c9 ***

cmd/cgo: pass -Wsystem-headers when looking for errors

This works around a bug in GCC 4.8.0.

Fixes issue 5118.

R=golang-dev, r, minux.ma
CC=golang-dev
https://codereview.appspot.com/9120045

Expand All Messages | Collapse All Messages