Issue 9119043: code review 9119043: cmd/ld: add .note.GNU-stack section for external linking

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9119043: code review 9119043: cmd/ld: add .note.GNU-stack section for external linking (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by minux1

Modified:
11 years, 10 months ago

Reviewers:

CC:
iant, r, golang-dev

Visibility:
Public.

Description

cmd/ld: add .note.GNU-stack section for external linking Fixes issue 5392.

Patch Set 1 #

Patch Set 2 : diff -r 123d0cef66f8 https://code.google.com/p/go #

Patch Set 3 : diff -r 123d0cef66f8 https://code.google.com/p/go #

Patch Set 4 : diff -r 123d0cef66f8 https://code.google.com/p/go #

Total comments: 2

Patch Set 5 : diff -r 740d244b2047 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 740d244b2047 https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
M	src/cmd/ld/elf.c	View	1 2 3 4	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/pkg/runtime/cgo/gcc_386.S	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_amd64.S	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/cgo/gcc_arm.S	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 10 months ago (2013-05-02 14:07:43 UTC) #1

iant

LGTM Thanks for working on this. I think this is good for 1.1 but please ...

11 years, 10 months ago (2013-05-03 02:01:25 UTC) #2

minux1

11 years, 10 months ago (2013-05-03 08:33:37 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=a5b289c0f5fb ***

cmd/ld: add .note.GNU-stack section for external linking
Fixes issue 5392.

R=iant, r
CC=golang-dev
https://codereview.appspot.com/9119043

Expand All Messages | Collapse All Messages