Issue 9117043: code review 9117043: goprotobuf: Allow groups to be treated as messages.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9117043: code review 9117043: goprotobuf: Allow groups to be treated as messages. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by dsymonds

Modified:
13 years, 6 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Allow groups to be treated as messages.

Patch Set 1 #

Patch Set 2 : diff -r dd932f914968 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r dd932f914968 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 521cfb326b2d https://code.google.com/p/goprotobuf #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -15 lines)			Patch
M	proto/clone.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	proto/equal.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	proto/size.go	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	proto/testdata/test.pb.go	View	1	7 chunks	+90 lines, -6 lines	0 comments	Download
M	protoc-gen-go/generator/generator.go	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go.golden	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

13 years, 6 months ago (2013-05-02 12:01:19 UTC) #1

dsymonds

13 years, 6 months ago (2013-05-02 22:52:04 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=a234ae124194 ***

goprotobuf: Allow groups to be treated as messages.

R=r
CC=golang-dev
https://codereview.appspot.com/9117043

Expand All Messages | Collapse All Messages