Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68)

Issue 9103046: code review 9103046: doc: only U+FEFF is a byte-order mark; U+FFFE is not (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by rsc
Modified:
11 years, 10 months ago
Reviewers:
alexb, nitrix
CC:
golang-dev, r
Visibility:
Public.

Description

doc: only U+FEFF is a byte-order mark; U+FFFE is not

Patch Set 1 #

Patch Set 2 : diff -r 3478ecc801f6 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 123d0cef66f8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 123d0cef66f8 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M doc/go1.1.html View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
11 years, 10 months ago (2013-05-02 18:49:55 UTC) #1
r
LGTM although really it's not that simple. unicode.org explicitly says that FFFE is not a ...
11 years, 10 months ago (2013-05-02 18:53:36 UTC) #2
rsc
Right, but in a Go program, only FEFF is allowed.
11 years, 10 months ago (2013-05-02 19:01:20 UTC) #3
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=9557a7d76d60 *** doc: only U+FEFF is a byte-order mark; U+FFFE is not ...
11 years, 10 months ago (2013-05-02 19:03:01 UTC) #4
nitrix
We can re-update the doc when U+FFFE is supported. For now I'd rather have something ...
11 years, 10 months ago (2013-05-02 19:06:19 UTC) #5
rsc
The implementation has always been correct; the doc now agrees. FFFE will not be supported. ...
11 years, 10 months ago (2013-05-02 19:10:57 UTC) #6
alexb_frankandoak.com
11 years, 10 months ago (2013-05-02 19:19:17 UTC) #7
Amazing then (:
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b