Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150)

Issue 9101043: Fix #1175183 broken filter checkboxes.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by rharding
Modified:
10 years, 11 months ago
Reviewers:
curtis, j.c.sackett, jeff.pihach, mp+161938
Visibility:
Public.

Description

Fix #1175183 broken filter checkboxes. - Y.Router comes with a _parseQuery method that does not parse lists of values. In production this was used due to the build process. - Include Y.QueryString in front of all Y.App code as the Y.Router will replace _parseQuery with Y.QueryString if it's available. https://code.launchpad.net/~rharding/juju-gui/filter_checkboxes_1175183/+merge/161938 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Attempt to fix #1175183 broken filter checkboxes. #

Patch Set 3 : Attempt to fix #1175183 broken filter checkboxes. #

Patch Set 4 : Fix #1175183 broken filter checkboxes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/index.html View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 8
rharding
Please take a look.
10 years, 11 months ago (2013-05-01 20:15:42 UTC) #1
j.c.sackett
LGMT; I'm game to see if this fixes it.
10 years, 11 months ago (2013-05-01 20:23:41 UTC) #2
j.c.sackett
On 2013/05/01 20:23:41, j.c.sackett wrote: > LGMT; I'm game to see if this fixes it. ...
10 years, 11 months ago (2013-05-01 20:23:49 UTC) #3
rharding
*** Submitted: Attempt to fix #1175183 broken filter checkboxes. - Submitting as TRIVIAL since it's ...
10 years, 11 months ago (2013-05-01 20:50:07 UTC) #4
rharding
Please take a look.
10 years, 11 months ago (2013-05-02 18:32:47 UTC) #5
jeff.pihach
LGTM!
10 years, 11 months ago (2013-05-02 18:37:52 UTC) #6
curtis
Thank you for the explanation. LGTM.
10 years, 11 months ago (2013-05-02 18:38:45 UTC) #7
rharding
10 years, 11 months ago (2013-05-02 18:44:22 UTC) #8
*** Submitted:

Fix #1175183 broken filter checkboxes.

- Y.Router comes with a _parseQuery method that does not parse lists of
values. In production this was used due to the build process.
- Include Y.QueryString in front of all Y.App code as the Y.Router will
replace _parseQuery with Y.QueryString if it's available.

R=jeff.pihach, curtis
CC=
https://codereview.appspot.com/9101043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b