Issue 9099043: Fixes #1174505 and #1175186 size icons on fullsc

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9099043: Fixes #1174505 and #1175186 size icons on fullsc

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rharding

Modified:
11 years ago

Reviewers:
bac, mp+161937, j.c.sackett

Visibility:
Public.

Description

Fixes #1174505 and #1175186 size icons on fullsc - On the fullscreen views for editorial/search results the icons should be 96x96 and 64x64 on the sidebar views. - Updated the charm-token widget to accept a size that is applied to the charm html as a css class. - Updated the charm-container to allow passing extra data to the container's children - Updated the view to set the size as additional child data. - Updated the CSS around the icons to support both 64 and 96 sizes - Set a default title text for the charm reviewed badge https://code.launchpad.net/~rharding/juju-gui/charm-token-size-1174505/+merge/161937 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes #1174505 and #1175186 size icons on fullsc #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -35 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/views/editorial.js	View	1	1 chunk	+31 lines, -18 lines	0 comments	Download
M	app/subapps/browser/views/search.js	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	app/templates/charm-token.handlebars	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	app/widgets/charm-container.js	View		2 chunks	+19 lines, -0 lines	0 comments	Download
M	app/widgets/charm-token.js	View		1 chunk	+14 lines, -1 line	0 comments	Download
M	lib/views/browser/charm-token.less	View		1 chunk	+19 lines, -8 lines	0 comments	Download
M	test/test_charm_container.js	View		3 chunks	+25 lines, -1 line	0 comments	Download
M	test/test_charm_token.js	View		4 chunks	+26 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

LGTM modulo one comment https://codereview.appspot.com/9099043/diff/1/app/subapps/browser/views/editorial.js File app/subapps/browser/views/editorial.js (right): https://codereview.appspot.com/9099043/diff/1/app/subapps/browser/views/editorial.js#newcode194 app/subapps/browser/views/editorial.js:194: } Is it the 2nd ...

11 years ago (2013-05-01 21:02:32 UTC) #3

rharding

11 years ago (2013-05-01 21:26:51 UTC) #4

*** Submitted:

Fixes #1174505 and #1175186 size icons on fullsc

- On the fullscreen views for editorial/search results the icons should be
96x96 and 64x64 on the sidebar views.
- Updated the charm-token widget to accept a size that is applied to the charm
html as a css class.
- Updated the charm-container to allow passing extra data to the container's
children
- Updated the view to set the size as additional child data.
- Updated the CSS around the icons to support both 64 and 96 sizes
- Set a default title text for the charm reviewed badge

R=j.c.sackett, bac
CC=
https://codereview.appspot.com/9099043

Expand All Messages | Collapse All Messages