Replaces spinner.gif with spin.js spinner

Replaces spinner.gif with spin.js spinner

This branch is the first part of standardizing our spinners in jujugui,
matching the ones used in the charmbrowser with the one when the canvas is
loading.

- Wraps a min version of spin.js in a YUI module.
- Uses that module in overlay-indicator.js

NB: This means there is a dupe of spin.js in the code tree. The spinner.gif is
still in the tree as well. I will do a follow up branch removing all of that,
but I wanted the user-facing bits working and solid before doing the cleanup.

https://code.launchpad.net/~jcsackett/juju-gui/spinners/+merge/164048

(do not edit description out of merge proposal)

[j.c.sackett, 2013-05-15 23:16:45]

Please take a look.

[jeff.pihach, 2013-05-16 04:03:29]

NOT LGTM - I stopped the review because this branch looks like it reverts all of
the new login/logout code - You'll likely need to create a new branch from trunk
and re apply your changes.

https://codereview.appspot.com/9095044/diff/1/app/app.js
File app/app.js (right):

https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode415
app/app.js:415: this.dispatch();
This will conflict with the changes in my current branch and using dispatch is
almost always unnecessary. Lets chat about what you were trying to accomplish
here.

https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode566
app/app.js:566: self.fire('navigateTo', {url: self.nsRouter.url(
This was changed to be a function call intentionally to avoid async routing
issues with the new login/logout code.

https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode582
app/app.js:582: self.fire('navigateTo', {url: self.nsRouter.url({gui: '/'})});
Same as above.

https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode701
app/app.js:701: * @method show_login
This was changed intentionally

https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode704
app/app.js:704: show_login: function() {
Same

[j.c.sackett, 2013-05-21 13:37:19]

On 2013/05/16 04:03:29, jeff.pihach wrote:
> NOT LGTM - I stopped the review because this branch looks like it reverts all
of
> the new login/logout code - You'll likely need to create a new branch from
trunk
> and re apply your changes.

Oh crap, you're right; I was blocked by that URL eating error I pointed out and
built on top of a branch that reverted that code. I'll fix that and send this
back up.

Sorry for the delay in reply; I have been out of town.
> 
> https://codereview.appspot.com/9095044/diff/1/app/app.js
> File app/app.js (right):
> 
> https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode415
> app/app.js:415: this.dispatch();
> This will conflict with the changes in my current branch and using dispatch is
> almost always unnecessary. Lets chat about what you were trying to accomplish
> here.
> 
> https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode566
> app/app.js:566: self.fire('navigateTo', {url: self.nsRouter.url(
> This was changed to be a function call intentionally to avoid async routing
> issues with the new login/logout code.
> 
> https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode582
> app/app.js:582: self.fire('navigateTo', {url: self.nsRouter.url({gui: '/'})});
> Same as above.
> 
> https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode701
> app/app.js:701: * @method show_login
> This was changed intentionally
> 
> https://codereview.appspot.com/9095044/diff/1/app/app.js#newcode704
> app/app.js:704: show_login: function() {
> Same

[j.c.sackett, 2013-05-21 17:28:31]

Please take a look.

[jeff.pihach, 2013-05-21 17:51:38]

LGTM Thanks for fixing that merge.

https://codereview.appspot.com/9095044/diff/6001/app/assets/javascripts/spinn...
File app/assets/javascripts/spinner.js (right):

https://codereview.appspot.com/9095044/diff/6001/app/assets/javascripts/spinn...
app/assets/javascripts/spinner.js:35: return new Spinner(Y.merge(defaults,
opts));
Should this cache an instance of the spinner so on multiple calls it returns one
already in memory?

[j.c.sackett, 2013-05-21 18:56:33]

https://codereview.appspot.com/9095044/diff/6001/app/assets/javascripts/spinn...
File app/assets/javascripts/spinner.js (right):

https://codereview.appspot.com/9095044/diff/6001/app/assets/javascripts/spinn...
app/assets/javascripts/spinner.js:35: return new Spinner(Y.merge(defaults,
opts));
On 2013/05/21 17:51:38, jeff.pihach wrote:
> Should this cache an instance of the spinner so on multiple calls it returns
one
> already in memory?

I don't think so. The overlays are using a manager that keeps track of spinners
and caches various instances that share the same config; the spinner when you
open the GUI is a somewhat different config, so we wouldn't want to save it and
use it elsewhere when we ask for a spinner.

[matthew.scott, 2013-05-21 18:59:00]

LGTM.  Thanks for the branch.  Gotta like JS spinners :)

[j.c.sackett, 2013-05-22 13:34:57]

*** Submitted:

Replaces spinner.gif with spin.js spinner

This branch is the first part of standardizing our spinners in jujugui,
matching the ones used in the charmbrowser with the one when the canvas is
loading.

- Wraps a min version of spin.js in a YUI module.
- Uses that module in overlay-indicator.js

NB: This means there is a dupe of spin.js in the code tree. The spinner.gif is
still in the tree as well. I will do a follow up branch removing all of that,
but I wanted the user-facing bits working and solid before doing the cleanup.

R=jeff.pihach, matthew.scott
CC=
https://codereview.appspot.com/9095044