code review 9082043: cmd/cgo: correct pragma name in comment

cmd/cgo: correct pragma name in comment

[iant, 2013-05-01 14:52:47]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[alexb_frankandoak.com, 2013-05-01 15:02:51]

Sure. LGTM.

On 2013-05-01, at 10:52 AM, iant@golang.org wrote:

> Reviewers: rsc,
> 
> Message:
> Hello rsc (cc: golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go
> 
> 
> Description:
> cmd/cgo: correct pragma name in comment
> 
> Please review this at https://codereview.appspot.com/9082043/
> 
> Affected files:
>  M src/cmd/cgo/doc.go
> 
> 
> Index: src/cmd/cgo/doc.go
> ===================================================================
> --- a/src/cmd/cgo/doc.go
> +++ b/src/cmd/cgo/doc.go
> @@ -472,7 +472,7 @@
> 	#pragma cgo_import_dynamic _ _ "libc.so.6"
> 
> 	For compatibility with current versions of SWIG,
> -	#pragma dynimport is an alias for #pragma cgo_dynamic_import.
> +	#pragma dynimport is an alias for #pragma cgo_import_dynamic.
> 
> #pragma cgo_dynamic_linker "<path>"
> 
> 
> 
> -- 
> 
> ---You received this message because you are subscribed to the Google Groups
"golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
> 
> 

[minux1, 2013-05-01 15:10:35]

https://codereview.appspot.com/9082043/diff/1/src/cmd/cgo/doc.go
File src/cmd/cgo/doc.go (right):

https://codereview.appspot.com/9082043/diff/1/src/cmd/cgo/doc.go#newcode466
src/cmd/cgo/doc.go:466: A side effect of the cgo_dynamic_import directive with a
also here.

https://codereview.appspot.com/9082043/diff/1/src/cmd/cgo/doc.go#newcode576
src/cmd/cgo/doc.go:576: particular foo.cgo2.o. To do so, it uses the
cgo_dynamic_import and
and here.

[iant, 2013-05-01 15:23:50]

On 2013/05/01 15:10:35, minux wrote:
> https://codereview.appspot.com/9082043/diff/1/src/cmd/cgo/doc.go
> File src/cmd/cgo/doc.go (right):
> 
> https://codereview.appspot.com/9082043/diff/1/src/cmd/cgo/doc.go#newcode466
> src/cmd/cgo/doc.go:466: A side effect of the cgo_dynamic_import directive with
a
> also here.
> 
> https://codereview.appspot.com/9082043/diff/1/src/cmd/cgo/doc.go#newcode576
> src/cmd/cgo/doc.go:576: particular foo.cgo2.o. To do so, it uses the
> cgo_dynamic_import and
> and here.

Thanks, updated.

[bradfitz, 2013-05-01 15:24:47]

LGTM



On Wed, May 1, 2013 at 8:23 AM, <iant@golang.org> wrote:

> On 2013/05/01 15:10:35, minux wrote:
>
>>
https://codereview.appspot.**com/9082043/diff/1/src/cmd/**cgo/doc.go<https://...
>> File src/cmd/cgo/doc.go (right):
>>
>
>
> https://codereview.appspot.**com/9082043/diff/1/src/cmd/**
>
cgo/doc.go#newcode466<https://codereview.appspot.com/9082043/diff/1/src/cmd/cgo/doc.go#newcode466>
>
>> src/cmd/cgo/doc.go:466: A side effect of the cgo_dynamic_import
>>
> directive with a
>
>> also here.
>>
>
>
> https://codereview.appspot.**com/9082043/diff/1/src/cmd/**
>
cgo/doc.go#newcode576<https://codereview.appspot.com/9082043/diff/1/src/cmd/cgo/doc.go#newcode576>
>
>> src/cmd/cgo/doc.go:576: particular foo.cgo2.o. To do so, it uses the
>> cgo_dynamic_import and
>> and here.
>>
>
> Thanks, updated.
>
>
https://codereview.appspot.**com/9082043/<https://codereview.appspot.com/9082...
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[minux1, 2013-05-01 15:25:22]

LGTM.

[nitrix, 2013-05-01 15:26:54]

LGTM

[iant, 2013-05-01 21:31:48]

*** Submitted as https://code.google.com/p/go/source/detail?r=e96ca5d8ecc3 ***

cmd/cgo: correct pragma name in comment

R=rsc, alexb, minux.ma, bradfitz, i.caught.air
CC=golang-dev
https://codereview.appspot.com/9082043