Issue 90820044: code review 90820044: go.net/ipv6: use unsafe.Pointer instead of uintptr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 90820044: code review 90820044: go.net/ipv6: use unsafe.Pointer instead of uintptr (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by mikio

Modified:
10 years, 10 months ago

Reviewers:
iant

CC:
golang-codereviews, iant

Visibility:
Public.

Description

go.net/ipv6: use unsafe.Pointer instead of uintptr Fixes issue 7173.

Patch Set 1 : diff -r 5dc21576b672 https://code.google.com/p/go.net #

Patch Set 2 : diff -r 5dc21576b672 https://code.google.com/p/go.net #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -39 lines)			Patch
M	ipv6/sockopt_rfc2292_unix.go	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	ipv6/sockopt_rfc3493_bsd.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv6/sockopt_rfc3493_linux.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv6/sockopt_rfc3493_unix.go	View	9 chunks	+13 lines, -13 lines	0 comments	Download
M	ipv6/sockopt_rfc3542_unix.go	View	6 chunks	+11 lines, -11 lines	0 comments	Download
M	ipv6/syscall_linux_386.go	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ipv6/syscall_nosplit4_linux_386.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv6/syscall_nosplit7_linux_386.go	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ipv6/syscall_unix.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-codereviews@googlegroups.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 10 months ago (2014-04-27 13:20:12 UTC) #1

mikio

10 years, 10 months ago (2014-04-28 02:32:25 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=424a15ce8b2f&repo=net ***

go.net/ipv6: use unsafe.Pointer instead of uintptr

Fixes issue 7173.

LGTM=iant
R=golang-codereviews, iant
CC=golang-codereviews
https://codereview.appspot.com/90820044

Expand All Messages | Collapse All Messages