Domado: Require declaration of private state at construction time.

Each private state record is made non-extensible after the object has
been constructed. Thus, all private fields must be created in the
constructor. This should make it easier to review how the private
namespace is being used.

Incidental changes:
* Rename .src to .scriptSrc to reduce the chances of a particularly
  dangerous name collision.
* Remove dead old-style editability flag setting in HTMLIFrameElement.

@r5400

[felix8a, 2013-05-04 01:14:43]

lgtm, but I'm finding it awkward to verify that all privates have had
preventExtensions called at the right time. is there some way to have it happen
in just one place like amplify or a variant of amplify?

[kpreid2, 2013-05-04 01:54:36]

On 2013/05/04 01:14:43, felix8a wrote:
> lgtm, but I'm finding it awkward to verify that all privates have had
> preventExtensions called at the right time. is there some way to have it
happen
> in just one place like amplify or a variant of amplify?

Unfortunately, there is no such place currently. Specifically, there is no
general single place which is 'after the constructor is done', due to the
presence of subtypes. In the case of tame nodes specifically, finishNode is that
single place (nodes are essentially created as finishNode(new tamingCtor(node)))
but there is no such place for all types-which-use-Confidence.

It would be nice if there *was* such a place. Do you have any suggestions for
how to cause it to exist? I don't have any good ideas yet.

[felix8a, 2013-05-06 16:29:13]

On 2013/05/04 01:54:36, kpreid2 wrote:
> On 2013/05/04 01:14:43, felix8a wrote:
> > lgtm, but I'm finding it awkward to verify that all privates have had
> > preventExtensions called at the right time. is there some way to have it
> happen
> > in just one place like amplify or a variant of amplify?
> 
> Unfortunately, there is no such place currently. Specifically, there is no
> general single place which is 'after the constructor is done', due to the
> presence of subtypes. In the case of tame nodes specifically, finishNode is
that
> single place (nodes are essentially created as finishNode(new
tamingCtor(node)))
> but there is no such place for all types-which-use-Confidence.
> 
> It would be nice if there *was* such a place. Do you have any suggestions for
> how to cause it to exist? I don't have any good ideas yet.

yeah, me neither. haven't yet thought of anything noticeably better than the
status quo