Issue 9077043: Port resizing_textarea from Launchpad.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9077043: Port resizing_textarea from Launchpad.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by bac

Modified:
11 years ago

Reviewers:
rharding, gary.poster, mp+161818

Visibility:
Public.

Description

Port resizing_textarea from Launchpad. Original is found at: http://bit.ly/18oTkNi And test at: http://bit.ly/159qJzt https://code.launchpad.net/~bac/juju-gui/rick-resizer/+merge/161818 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Port resizing_textarea from Launchpad. #

Total comments: 1

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+639 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	app/assets/javascripts/resizing_textarea.js	View	1	1 chunk	+327 lines, -0 lines	1 comment	Download
M	app/modules-debug.js	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	bin/merge-files	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	test/index.html	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	test/test_resizing_textarea.js	View		1 chunk	+301 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gary.poster

LGTM. I'm really sorry about the path you had to take to get here, but ...

11 years ago (2013-05-01 13:31:37 UTC) #2

rharding

LGTM with one comment. Thanks for porting it over. https://codereview.appspot.com/9077043/diff/1/app/assets/javascripts/resizing_textarea.js File app/assets/javascripts/resizing_textarea.js (right): https://codereview.appspot.com/9077043/diff/1/app/assets/javascripts/resizing_textarea.js#newcode316 app/assets/javascripts/resizing_textarea.js:316: ...

11 years ago (2013-05-01 14:28:10 UTC) #3

bac

*** Submitted: Port resizing_textarea from Launchpad. Original is found at: http://bit.ly/18oTkNi And test at: http://bit.ly/159qJzt ...

11 years ago (2013-05-01 15:08:00 UTC) #4

rharding

11 years ago (2013-05-01 21:16:57 UTC) #5

possible fix to double clone issue.

https://codereview.appspot.com/9077043/diff/6001/app/assets/javascripts/resiz...
File app/assets/javascripts/resizing_textarea.js (right):

https://codereview.appspot.com/9077043/diff/6001/app/assets/javascripts/resiz...
app/assets/javascripts/resizing_textarea.js:147: return
clone_one.get('scrollHeight');
var height = clone_one.get('scrollHeight');
clone_one.remote(true);
return height;

Expand All Messages | Collapse All Messages