Move RepoSuite to live alongside JujuConnSuite

Move RepoSuite to live alongside JujuConnSuite

This is the first step to implementing the upgrade-charm command, so that many of the tests involved with upgrading a charm can be performed from the statecmd_test package.  This is a mostly mechanical change that moves the RepoSuite from just the cmd/juju package to juju/testing.  The next step will be to refactor the deploy API command to be a proper statecmd, which can then be tested properly (it isn't, at the moment).  Finally, as portions of the upgrade-charm statecmd will require deploying charms, the upgrade charm command can be moved to statecmd and tested properly.  These branches will be proposed in order with requisites.

https://code.launchpad.net/~makyo/juju-core/reposuite-refactor/+merge/162457

(do not edit description out of merge proposal)

[matthew.scott, 2013-05-03 19:40:44]

Please take a look.

[teknico, 2013-05-14 16:28:34]

LGTM. Mostly mechanical changes, as you said.

[bac, 2013-05-15 17:52:21]

LGTM

[fwereade, 2013-05-16 08:00:20]

just a comment

https://codereview.appspot.com/9074045/diff/1/juju/testing/repo.go
File juju/testing/repo.go (right):

https://codereview.appspot.com/9074045/diff/1/juju/testing/repo.go#newcode19
juju/testing/repo.go:19: JujuConnSuite
FWIW, JujuConnSuite is evil and broken (because it sets up contradictory state
-- both for a client env, and for an agent env), but I understand this is just a
move. If you end up changing JCS in a followup, though, please make sure you
don't further entrench this issue.

[matthew.scott, 2013-05-16 15:43:15]

*** Submitted:

Move RepoSuite to live alongside JujuConnSuite

This is the first step to implementing the upgrade-charm command, so that many
of the tests involved with upgrading a charm can be performed from the
statecmd_test package.  This is a mostly mechanical change that moves the
RepoSuite from just the cmd/juju package to juju/testing.  The next step will be
to refactor the deploy API command to be a proper statecmd, which can then be
tested properly (it isn't, at the moment).  Finally, as portions of the
upgrade-charm statecmd will require deploying charms, the upgrade charm command
can be moved to statecmd and tested properly.  These branches will be proposed
in order with requisites.

R=teknico, bac, fwereade
CC=
https://codereview.appspot.com/9074045