Fixed sidebar shadow.

Fixed sidebar shadow.

Fix to make the shadow on the sidebar overlap the content.

https://code.launchpad.net/~huwshimi/juju-gui/sidebar-shadow/+merge/161781

(do not edit description out of merge proposal)

[huwshimi, 2013-05-01 06:34:01]

Please take a look.

[rharding, 2013-05-01 11:59:08]

LGTM, trivial like this you can label it TRIVIAL in the commit message and self
review and lbox submit -v to land.

[gary.poster, 2013-05-01 12:35:57]

Not LGTM.  This was a change I made to make the environment help text be hidden.

I'm not sure what you are accomplishing exactly: maybe you can make the sidebar
have a z-index of 2, and keep the z-indexes of 1 for the other two?

[huwshimi, 2013-05-01 23:35:57]

On 2013/05/01 12:35:57, gary.poster wrote:
> Not LGTM.  This was a change I made to make the environment help text be
hidden.
> 
> I'm not sure what you are accomplishing exactly: maybe you can make the
sidebar
> have a z-index of 2, and keep the z-indexes of 1 for the other two?

Ah that makes sense, I had a look when I made the change and couldn't see
anything that broke, but I guess I probably wasn't looking at an empty canvas.
I'll update.

[gary.poster, 2013-05-02 00:05:02]

On 2013/05/01 23:35:57, huwshimi wrote:
> On 2013/05/01 12:35:57, gary.poster wrote:
> > Not LGTM.  This was a change I made to make the environment help text be
> hidden.
> > 
> > I'm not sure what you are accomplishing exactly: maybe you can make the
> sidebar
> > have a z-index of 2, and keep the z-indexes of 1 for the other two?
> 
> Ah that makes sense, I had a look when I made the change and couldn't see
> anything that broke, but I guess I probably wasn't looking at an empty canvas.
> I'll update.

Thanks.  LGTM with that.

[huwshimi, 2013-05-02 00:24:05]

*** Submitted:

Fixed sidebar shadow.

Fix to make the shadow on the sidebar overlap the content.

R=rharding, gary.poster
CC=
https://codereview.appspot.com/9069043