Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 9064044: code review 9064044: go/build: document GOOS.go also has implicit GOOS build... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by minux1
Modified:
11 years, 10 months ago
Reviewers:
CC:
golang-dev, nitrix, alexb_frankandoak.com, r
Visibility:
Public.

Description

go/build: document GOOS.go also has implicit GOOS build constraint

Patch Set 1 #

Patch Set 2 : diff -r 987b23a69416 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 987b23a69416 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r 987b23a69416 https://code.google.com/p/go/ #

Patch Set 5 : diff -r 987b23a69416 https://code.google.com/p/go/ #

Total comments: 4

Patch Set 6 : diff -r 987b23a69416 https://code.google.com/p/go/ #

Patch Set 7 : diff -r 987b23a69416 https://code.google.com/p/go/ #

Patch Set 8 : diff -r 112ea225794f https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M src/pkg/go/build/doc.go View 1 2 3 4 5 6 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 9
minux1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 10 months ago (2013-05-03 19:44:45 UTC) #1
nitrix
Approved on my side.
11 years, 10 months ago (2013-05-03 20:25:28 UTC) #2
alexb_frankandoak.com
LGTM
11 years, 10 months ago (2013-05-03 20:34:19 UTC) #3
r
https://codereview.appspot.com/9064044/diff/5001/src/pkg/go/build/doc.go File src/pkg/go/build/doc.go (right): https://codereview.appspot.com/9064044/diff/5001/src/pkg/go/build/doc.go#newcode100 src/pkg/go/build/doc.go:100: // matches GOOS, GOARCH, *_GOOS, *_GOARCH, or *_GOOS_GOARCH for ...
11 years, 10 months ago (2013-05-03 20:37:23 UTC) #4
minux1
Hello golang-dev@googlegroups.com, i.caught.air@gmail.com, alexb@frankandoak.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
11 years, 10 months ago (2013-05-03 21:23:33 UTC) #5
r
https://codereview.appspot.com/9064044/diff/17001/src/pkg/go/build/doc.go File src/pkg/go/build/doc.go (right): https://codereview.appspot.com/9064044/diff/17001/src/pkg/go/build/doc.go#newcode100 src/pkg/go/build/doc.go:100: // matches any of the following pattens: s/pattens/patterns/ https://codereview.appspot.com/9064044/diff/17001/src/pkg/go/build/doc.go#newcode104 ...
11 years, 10 months ago (2013-05-03 21:28:59 UTC) #6
minux1
All typo fixed, PTAL.
11 years, 10 months ago (2013-05-03 21:36:39 UTC) #7
r
LGTM
11 years, 10 months ago (2013-05-03 21:57:07 UTC) #8
minux1
11 years, 10 months ago (2013-05-04 18:23:40 UTC) #9 
*** Submitted as https://code.google.com/p/go/source/detail?r=8cca28e940ea ***

go/build: document GOOS.go also has implicit GOOS build constraint

R=golang-dev, i.caught.air, alexb, r
CC=golang-dev
https://codereview.appspot.com/9064044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b