code review 9060045: runtime/cgo: export symbols in both internal and extern...

runtime/cgo: export symbols in both internal and external link mode

[iant, 2013-05-01 14:28:12]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[rsc, 2013-05-01 15:46:58]

LGTM

[r, 2013-05-01 21:25:42]

LGTM

[iant, 2013-05-01 21:31:05]

*** Submitted as https://code.google.com/p/go/source/detail?r=a41f95be3187 ***

runtime/cgo: export symbols in both internal and external link mode

R=rsc, r
CC=golang-dev
https://codereview.appspot.com/9060045

[ajstarks, 2013-05-02 11:08:24]

On 2013/05/01 21:31:05, iant wrote:
> *** Submitted as https://code.google.com/p/go/source/detail?r=a41f95be3187 ***
> 
> runtime/cgo: export symbols in both internal and external link mode
> 
> R=rsc, r
> CC=golang-dev
> https://codereview.appspot.com/9060045

This revision causes the misc/cgo/test to fail on arm, see
https://code.google.com/p/go/issues/detail?id=5387

# ../misc/cgo/test
/tmp/go-build428583550/_/home/pi/go/misc/cgo/test/_test/test.test: symbol lookup
error: /tmp/go-build428583550/_/home/pi/go/misc/cgo/test/_test/test.test:
undefined symbol: SansTypeface
exit status 127
FAIL	_/home/pi/go/misc/cgo/test	0.014s
/tmp/go-build903371114/_/home/pi/go/misc/cgo/test/_test/test.test: symbol lookup
error: /tmp/go-build903371114/_/home/pi/go/misc/cgo/test/_test/test.test:
undefined symbol: SansTypeface
exit status 127
FAIL	_/home/pi/go/misc/cgo/test	0.015s

[minux1, 2013-05-02 11:09:50]

On Thu, May 2, 2013 at 7:08 PM, <ajstarks@gmail.com> wrote:

> This revision causes the misc/cgo/test to fail on arm, see
>
https://code.google.com/p/go/**issues/detail?id=5387<https://code.google.com/...

I'm on it.

>
> # ../misc/cgo/test
> /tmp/go-build428583550/_/home/**pi/go/misc/cgo/test/_test/**test.test:
> symbol lookup error:
> /tmp/go-build428583550/_/home/**pi/go/misc/cgo/test/_test/**test.test:
> undefined symbol: SansTypeface
> exit status 127
> FAIL    _/home/pi/go/misc/cgo/test      0.014s
> /tmp/go-build903371114/_/home/**pi/go/misc/cgo/test/_test/**test.test:
> symbol lookup error:
> /tmp/go-build903371114/_/home/**pi/go/misc/cgo/test/_test/**test.test:
> undefined symbol: SansTypeface
> exit status 127
> FAIL    _/home/pi/go/misc/cgo/test      0.015s
>
>
>
>
https://codereview.appspot.**com/9060045/<https://codereview.appspot.com/9060...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[minux1, 2013-05-02 16:02:58]

On Thu, May 2, 2013 at 7:09 PM, minux <minux.ma@gmail.com> wrote:

>
> On Thu, May 2, 2013 at 7:08 PM, <ajstarks@gmail.com> wrote:
>
>> This revision causes the misc/cgo/test to fail on arm, see
>>
https://code.google.com/p/go/**issues/detail?id=5387<https://code.google.com/...
>
> I'm on it.
>
It's fixed by rev 123d0cef66f8.
>
>
>> # ../misc/cgo/test
>> /tmp/go-build428583550/_/home/**pi/go/misc/cgo/test/_test/**test.test:
>> symbol lookup error:
>> /tmp/go-build428583550/_/home/**pi/go/misc/cgo/test/_test/**test.test:
>> undefined symbol: SansTypeface
>> exit status 127
>> FAIL    _/home/pi/go/misc/cgo/test      0.014s
>> /tmp/go-build903371114/_/home/**pi/go/misc/cgo/test/_test/**test.test:
>> symbol lookup error:
>> /tmp/go-build903371114/_/home/**pi/go/misc/cgo/test/_test/**test.test:
>> undefined symbol: SansTypeface
>> exit status 127
>> FAIL    _/home/pi/go/misc/cgo/test      0.015s
>>
>>
>>
>>
https://codereview.appspot.**com/9060045/<https://codereview.appspot.com/9060...
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
>> .
>> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
>> .
>>
>>
>>
>