Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(395)

Issue 9057046: Experimental solution for printing tracebacks more often (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by GvR
Modified:
10 years, 11 months ago
Reviewers:
Nikolay Kim, gvrpython
Visibility:
Public.

Description

Experimental solution for printing tracebacks more often

Patch Set 1 #

Patch Set 2 : Here's a completely different approach #

Patch Set 3 : A solid version of the previous hack, with tests etc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -92 lines) Patch
M tests/futures_test.py View 1 2 1 chunk +22 lines, -42 lines 0 comments Download
M tulip/futures.py View 1 2 7 chunks +68 lines, -47 lines 0 comments Download
M tulip/tasks.py View 1 2 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8
GvR
So, the little test program below does print a traceback with this code in place. ...
10 years, 11 months ago (2013-05-03 16:45:57 UTC) #1
Nikolay Kim
On 2013/05/03 16:45:57, GvR wrote: > So, the little test program below does print a ...
10 years, 11 months ago (2013-05-03 18:11:20 UTC) #2
gvrpython
On Fri, May 3, 2013 at 11:11 AM, <fafhrd91@gmail.com> wrote: > On 2013/05/03 16:45:57, GvR ...
10 years, 11 months ago (2013-05-03 19:00:54 UTC) #3
GvR
Patch Set 2 is my new idea. Get rid of the __del__ on the Future, ...
10 years, 11 months ago (2013-05-03 19:26:54 UTC) #4
Nikolay Kim
On 2013/05/03 19:26:54, GvR wrote: > Patch Set 2 is my new idea. > > ...
10 years, 11 months ago (2013-05-03 19:35:48 UTC) #5
gvrpython
On Fri, May 3, 2013 at 12:35 PM, <fafhrd91@gmail.com> wrote: > i like the idea. ...
10 years, 11 months ago (2013-05-03 20:56:17 UTC) #6
GvR
Please review.
10 years, 11 months ago (2013-05-03 22:08:26 UTC) #7
Nikolay Kim
10 years, 11 months ago (2013-05-03 22:12:01 UTC) #8
LGTM!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b