Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(141)

Issue 90540043: http: close response body if unused

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 1 month ago by axw
Modified:
6 years, 1 month ago
Reviewers:
jameinel, mp+216822
Visibility:
Public.

Description

http: close response body if unused BinaryRequest calls may discard the response without closing it. This was causing sockets to be left open in juju-core/provider/openstack tests, leading to test failures. https://code.launchpad.net/~axwalk/goose/close-response/+merge/216822 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M http/client.go View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2
axw
Please take a look.
6 years, 1 month ago (2014-04-23 07:18:27 UTC) #1
jameinel
6 years, 1 month ago (2014-04-23 07:22:31 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b