Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1143)

Issue 9052043: Show spinny indicator in browser when loading

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by rharding
Modified:
9 years, 7 months ago
Reviewers:
matthew.scott, gary.poster, mp+161649
Visibility:
Public.

Description

Show spinny indicator in browser when loading - add indicator support to sidebar/fullscreen landing pages - add indicator support to the search loading - add indicator support to loading a charm details view https://code.launchpad.net/~rharding/juju-gui/loading-indicators/+merge/161649 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Show spinny indicator in browser when loading #

Patch Set 3 : Show spinny indicator in browser when loading #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/views/charm.js View 3 chunks +21 lines, -1 line 0 comments Download
M app/subapps/browser/views/editorial.js View 4 chunks +6 lines, -1 line 0 comments Download
M app/subapps/browser/views/search.js View 3 chunks +3 lines, -0 lines 0 comments Download
M app/views/utils.js View 1 chunk +5 lines, -0 lines 0 comments Download
M test/test_browser_charm_details.js View 1 chunk +24 lines, -0 lines 0 comments Download
M test/test_browser_editorial.js View 1 chunk +28 lines, -0 lines 0 comments Download
M test/test_browser_search_view.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rharding
Please take a look.
9 years, 7 months ago (2013-04-30 16:58:47 UTC) #1
rharding
Please take a look.
9 years, 7 months ago (2013-04-30 17:02:10 UTC) #2
matthew.scott
LGTM - thanks for the spinners!
9 years, 7 months ago (2013-04-30 17:10:55 UTC) #3
gary.poster
I did not QA but the code LGTM. Please let me know if you would ...
9 years, 7 months ago (2013-04-30 17:57:19 UTC) #4
rharding
9 years, 7 months ago (2013-04-30 18:04:49 UTC) #5
*** Submitted:

Show spinny indicator in browser when loading

- add indicator support to sidebar/fullscreen landing pages
- add indicator support to the search loading
- add indicator support to loading a charm details view

R=matthew.scott, gary.poster
CC=
https://codereview.appspot.com/9052043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b