code review 90440043: runtime: heapdump - make sure span is still in use afte...

runtime: heapdump - make sure spans are swept before dumping.

[khr, 2014-04-22 20:57:46]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://khr%40golang.org@code.google.com/p/go/

[khr, 2014-04-22 20:58:54]

On 2014/04/22 20:57:46, khr wrote:
> Hello mailto:golang-codereviews@googlegroups.com,
> 
> I'd like you to review this change to
> https://khr%40golang.org@code.google.com/p/go/

Alan, this fixes the "fatal error: free array doesn't have enough entries" bug.

[adonovan, 2014-04-22 21:13:46]

On 2014/04/22 20:58:54, khr wrote:
> On 2014/04/22 20:57:46, khr wrote:
> > Hello mailto:golang-codereviews@googlegroups.com,
> > 
> > I'd like you to review this change to
> > https://khr%40golang.org@code.google.com/p/go/
> 
> Alan, this fixes the "fatal error: free array doesn't have enough entries"
bug.

Thanks---though you should probably have rsc review it.

[khr, 2014-04-23 21:29:49]

On 2014/04/22 21:13:46, adonovan wrote:
> On 2014/04/22 20:58:54, khr wrote:
> > On 2014/04/22 20:57:46, khr wrote:
> > > Hello mailto:golang-codereviews@googlegroups.com,
> > > 
> > > I'd like you to review this change to
> > > https://khr%40golang.org@code.google.com/p/go/
> > 
> > Alan, this fixes the "fatal error: free array doesn't have enough entries"
> bug.
> 
> Thanks---though you should probably have rsc review it.

Russ, could you take a quick look?

[rsc, 2014-04-28 16:36:20]

LGTM

[khr, 2014-04-28 16:45:51]

*** Submitted as https://code.google.com/p/go/source/detail?r=16f1a9eb64f9 ***

runtime: heapdump - make sure spans are swept before dumping.

LGTM=rsc
R=golang-codereviews, adonovan, rsc
CC=golang-codereviews
https://codereview.appspot.com/90440043