Issue 9040047: code review 9040047: libmach: fix build on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9040047: code review 9040047: libmach: fix build on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by 0intro

Modified:
11 years, 9 months ago

Reviewers:
r, lucio

CC:
golang-dev, r

Visibility:
Public.

Description

libmach: fix build on Plan 9 Include libc.h before bio.h in 8.c, because bio.h uses the UTFmax enum, which is declared in libc.h, since the recent switch to 21-bit runes in Plan 9. The 5.c and 6.c files already includes libc.h.

Patch Set 1 #

Patch Set 2 : diff -r 3478ecc801f6 https://code.google.com/p/go #

Patch Set 3 : diff -r 3478ecc801f6 https://code.google.com/p/go #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/libmach/8.c	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

0intro

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 10 months ago (2013-05-01 18:42:11 UTC) #1

*** Submitted as https://code.google.com/p/go/source/detail?r=dd46e4436dbc *** libmach: fix build on Plan 9 Include libc.h before bio.h ...

11 years, 10 months ago (2013-05-01 22:48:16 UTC) #3

lucio

11 years, 10 months ago (2013-05-03 04:16:07 UTC) #4

Thank you, David.

I was away for a couple of days and that had me baffled.

Lucio.

On 5/1/13, 0intro@gmail.com <0intro@gmail.com> wrote:
>
> Description:
> libmach: fix build on Plan 9
>
> Include libc.h before bio.h in 8.c, because bio.h use
> the UTFmax enum, which is declared in libc.h, since
> the recent switch to 21-bit runes in Plan 9.
>

Expand All Messages | Collapse All Messages