Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(203)

Issue 90400044: code review 90400044: os/exec: deflake a test on Linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by bradfitz
Modified:
11 years ago
Reviewers:
gobot, iant
CC:
golang-codereviews, iant, adg
Visibility:
Public.

Description

os/exec: deflake a test on Linux Work around buggy(?) Linux /proc filesystem. Fixes Issue 7808

Patch Set 1 #

Patch Set 2 : diff -r 0d6275354408 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0d6275354408 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f8b50ad4cac4 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M src/pkg/os/exec/exec_test.go View 1 1 chunk +15 lines, -4 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-codereviews@googlegroups.com (cc: adg@golang.org, iant@golang.org), I'd like you to review this change to https://go.googlecode.com/hg/
11 years ago (2014-04-22 23:48:09 UTC) #1
iant
LGTM
11 years ago (2014-04-23 00:01:26 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=74a1371ffaf1 *** os/exec: deflake a test on Linux Work around buggy(?) Linux ...
11 years ago (2014-04-23 00:13:43 UTC) #3
gobot
11 years ago (2014-04-23 00:22:24 UTC) #4
Message was sent while issue was closed.
This CL appears to have broken the freebsd-386 builder.
See http://build.golang.org/log/52e93ec40f58434123c38bda5500e85dea07fd3a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b