Issue 9039045: code review 9039045: cmd/ld: fix check for address wrap in relocation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 9039045: code review 9039045: cmd/ld: fix check for address wrap in relocation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by r

Modified:
11 years, 10 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/ld: fix check for address wrap in relocation PC-relative needs a signed offset; others need unsigned. Also fix signedness of 32-bit relocation on Windows.

Patch Set 1 #

Patch Set 2 : diff -r 9bf97fe54385 https://code.google.com/p/go/ #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	src/cmd/ld/data.c	View		1 chunk	+1 line, -2 lines	0 comments	Download
	M	src/cmd/ld/ldpe.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 10 months ago (2013-04-30 15:40:15 UTC) #1

11 years, 10 months ago (2013-04-30 16:10:01 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=a773ae948d66 ***

cmd/ld: fix check for address wrap in relocation
PC-relative needs a signed offset; others need unsigned.
Also fix signedness of 32-bit relocation on Windows.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/9039045

Expand All Messages | Collapse All Messages